Reported by Arran Cudbard-Bell <a.cudbardb@freeradius.org>. Patch and regression tests to follow.
Created attachment 16296 [details] Add additional debug text to memlimit tests
Created attachment 16297 [details] Add additional test cases for memlimit
Created attachment 16298 [details] Add note in doxygen about how memlimit interacts with pools
Jeremy, the final patch submitted to samba-technical looks good to me. I've attached the same patches as I posted. I think once these are all merged we can considered this bug resolved.
Gonna need a little more - the additional test should go in first marked as "knownfail", then the patch that fixes them removes them from the knownfail directory again. I'm working on it..
gitlab: https://gitlab.com/samba-team/devel/samba/-/merge_requests/new?merge_request%5Bsource_branch%5D=jra-talloc-bug-14540 running CI tests first.
Created attachment 16313 [details] git-am fix for master.
Created attachment 16314 [details] Updated with sigs files.
MR: https://gitlab.com/samba-team/samba/-/merge_requests/1646
This bug was referenced in samba master: 86eb6423bdcedf3433f3dbcf026573a238cf0d87 6e0aab0b4038255b2d63e8687924a21d77bace91 30a8bea8a340dcf9a3120f5ee8041e62fb129d8d 4566ee91b8c37f62e8b56242a48230db59cd5ff0 a5052c73c3ffdca6b30194223e69a26430f3f989
Not sure if we need to back-port this to 4.13.next, or just leave until 4.14. Arran, do you have an opinion on this ?
It's not especially urgent as we have a work around, so I'm fine with leaving it until 4.14.