Bug 14466 fixed a ctdb disable/enable race but left another behind. The recovery daemon (node A) updates its flags from remote node B and pushes changed flags for B out to all nodes. However, if a third node (C) had different flags for node B then the recovery daemon's copy of these flags is not updated. However, the recovery daemon's main loop sanity checks C's potentially stale copy of flags for B with its own flags for B. If these differ then it can overwrite flags in an undesirable way, cancelling a disable/enable. The recovery daemon is better off not doing such sanity check and should just depend on update_flags() working.
This bug was referenced in samba master: 3ab52b528673e08caa66f00e963528c591a84fe1 4b01f54041dee469971f244e64064eed46de2ed5 b68105b8f7c20692d23d457f2777edcf44f12bb8
Created attachment 16278 [details] Patch for 4.13 Patch from master cherry-picks cleanly into v4-13-test. Successfully regression tested, no surprises.
Created attachment 16279 [details] Patch for 4.12 Patch from master cherry-picks cleanly into v4-12-test - this is actually the same patch as for v4-12-test. Successfully regression tested, no surprises.
Created attachment 16280 [details] Patch for 4.11 I'm not sure if there will be another bug fix 4.11 release. If not, please ignore this. The final commit from master that strengthens the relevant testcase does not apply cleanly to v4-11-test so I have dropped it from this "backport", since it mostly exists to protect us from potential breakage from future changes. The other 2 commits for the code changes apply cleanly. I did a smoke test (ran the relevant testcase against local daemons) and it passes as expected.
Hi Karolin, This is ready for v4-11 (if we are taking bug fixes), v4-12 and v4-13. Thanks.
(In reply to Amitay Isaacs from comment #5) Hi Amitay, pushed to autobuild-v4-{13,12}-test. 4.11 is security fixes only. Thanks! Karo
This bug was referenced in samba v4-12-test: 91a8a9a98508aedf3d07bf83e5e53342fe74bdf5 3a4def14560501db1fd226aa9ebd729b2b061542 3a1d5236678eb126d30b07602dd73d99b707aff8
This bug was referenced in samba v4-13-test: 895bc9a7c2aa6fab2029618d1267d97f705c4b1b 710b287bdc99eb40b31eed6f952d9cd83f7e64a3 e759ecdae11aff98847236cab46dd26fbb7ba90b
Closing out bug report. Thanks!
This bug was referenced in samba v4-13-stable (Release samba-4.13.2): 895bc9a7c2aa6fab2029618d1267d97f705c4b1b 710b287bdc99eb40b31eed6f952d9cd83f7e64a3 e759ecdae11aff98847236cab46dd26fbb7ba90b
This bug was referenced in samba v4-12-stable (Release samba-4.12.10): 91a8a9a98508aedf3d07bf83e5e53342fe74bdf5 3a4def14560501db1fd226aa9ebd729b2b061542 3a1d5236678eb126d30b07602dd73d99b707aff8