Bug 14492 - Minshall-French symlinks cannot be searched for with "find . -type l"
Summary: Minshall-French symlinks cannot be searched for with "find . -type l"
Status: ASSIGNED
Alias: None
Product: CifsVFS
Classification: Unclassified
Component: kernel fs (show other bugs)
Version: 3.x
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: Steve French
QA Contact: cifs QA contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-15 02:02 UTC by Micah Veilleux
Modified: 2023-10-13 03:34 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Micah Veilleux 2020-09-15 02:02:44 UTC 
Minshall-French symlinks are identified by "find" as files rather than symbolic links:
------------------------------
mcrs3:/TCS # grep "TCS " /etc/fstab
//mcrs3/TCS /TCS cifs user=cifsuser,multiuser,domain=VPTC3,sec=krb5,mfsymlinks,vers=3.0 0 0
mcrs3:/TCS #
mcrs3:/TCS # touch testfile
mcrs3:/TCS # ln -s testfile testlink
mcrs3:/TCS #
mcrs3:/TCS # find . -type l
mcrs3:/TCS # find . -type f | grep test
./testlink
./testfile
mcrs3:/TCS #
mcrs3:/TCS # stat testlink
  File: testlink -> testfile
  Size: 8           Blocks: 16         IO Block: 16384  symbolic link
Device: 2ch/44d Inode: 10941196461752524492  Links: 1
Access: (0777/lrwxrwxrwx)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2020-09-11 20:24:54.163302900 +0200
Modify: 2020-09-11 20:24:26.146021300 +0200
Change: 2020-09-11 20:24:26.146021300 +0200
 Birth: -
mcrs3:/TCS #
------------------------------

Version of sernet-samba is: 99:4.12.2-11.suse150

The underlying issue could be the same as for bug 14476.
Comment 1 Steve French 2020-09-15 18:24:42 UTC 
I can reproduce this to Samba as well.  Investigating
Comment 2 Steve French 2020-09-15 18:27:15 UTC 
Presumably have to flag files which are 1067 bytes with an additional check before returning their file type in readdir
Comment 3 Björn Jacke 2023-10-12 12:36:47 UTC 
Any update on this? Bumped into this again, I thought this would have been fixed since long.
Comment 4 Steve French 2023-10-13 03:34:13 UTC 
good catch - this one may have slipped through (we also ought to add a small xfstest or equivalent for this so it doesn't cause problems in the future or show up with Samba reparse points in the future etc.).

Will take a look
Comment 5 Steve French 2023-10-13 03:34:27 UTC 
good catch - this one may have slipped through (we also ought to add a small xfstest or equivalent for this so it doesn't cause problems in the future or show up with Samba reparse points in the future etc.).

Will take a look