Bug 14490 - smbd is logging success as error
Summary: smbd is logging success as error
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.11.12
Hardware: All All
: P5 minor (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
Depends on:
Reported: 2020-09-11 12:24 UTC by Philipp Gesang
Modified: 2020-09-25 08:45 UTC (History)
2 users (show)

See Also:

0001-smbd-don-t-log-success-as-error.patch (1.85 KB, patch)
2020-09-11 12:26 UTC, Philipp Gesang
jra: review+
slow: review+
metze: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Gesang 2020-09-11 12:24:44 UTC
This appears to be only present in 4.11.12.

58bc493 promoted an error message in remove_share_mode_lease
to DBGLVL_ERR unless the status is NT_STATUS_NOT_FOUND. There
is no guard for NT_STATUS_OK though so that “error” is logged
for all successful calls too. (4.12 and 4.13 have the guard.)

CI for the patch:
Comment 1 Philipp Gesang 2020-09-11 12:26:54 UTC
Created attachment 16222 [details]
Comment 2 Philipp Gesang 2020-09-11 13:43:45 UTC
CI is all green. Which branch on Gitlab should this be filed against?
Comment 3 Jeremy Allison 2020-09-11 17:11:52 UTC
Good catch. This should be turned into a merge request. Once it's got 2 team review (and you have one +1 right here :-) then I can push it to master.
Comment 4 Jeremy Allison 2020-09-11 22:37:32 UTC
Ah, sorry - I was confused. Code is not in master.

Applies cleanly to 4.11.next.
Comment 5 Jeremy Allison 2020-09-11 22:38:17 UTC
Comment on attachment 16222 [details]

LGTM = jra.
Comment 6 Jeremy Allison 2020-09-11 22:39:06 UTC
Ralph or Metze, can you +1 this and we can get it into 4.11.next.

Thanks !

Comment 7 Karolin Seeger 2020-09-16 07:05:33 UTC
Pushed to autobuild-v4-11-test.
Comment 8 Karolin Seeger 2020-09-25 08:45:00 UTC
(In reply to Karolin Seeger from comment #7)
Pushed to v4-11-test.
Closing out bug report.