Bug 14450 - samba-tool domain backup rename can fail if there are dangling one-way links
Summary: samba-tool domain backup rename can fail if there are dangling one-way links
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: 4.13.0.rc1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-26 23:34 UTC by Andrew Bartlett
Modified: 2020-08-11 07:22 UTC (History)
3 users (show)

See Also:


Attachments
patch from master backported to 4.12 (4.14 KB, patch)
2020-07-29 10:20 UTC, Andrew Bartlett
dbagnall: review+
Details
patch from master backported to 4.13 (4.14 KB, patch)
2020-07-29 10:32 UTC, Andrew Bartlett
dbagnall: review+
Details
patch from master backported to 4.11 (4.14 KB, patch)
2020-07-29 10:42 UTC, Andrew Bartlett
dbagnall: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2020-07-26 23:34:45 UTC
Because of the way the rename is handled in the lab domain creation tool 'samba-tool domain backup rename' a dangling link to an expunged object will point outside our NCs once the rename is complete.

This causes an un-handled exception in part of dbcheck used to finish the rename work.

We may choose to try and handle this in the rename tool in the future, but for now this avoids crashing out the whole rename.
Comment 1 Andrew Bartlett 2020-07-29 10:20:46 UTC
Created attachment 16150 [details]
patch from master backported to 4.12
Comment 2 Andrew Bartlett 2020-07-29 10:32:03 UTC
Created attachment 16151 [details]
patch from master backported to 4.13
Comment 3 Andrew Bartlett 2020-07-29 10:42:20 UTC
Created attachment 16152 [details]
patch from master backported to 4.11
Comment 4 Andrew Bartlett 2020-07-30 05:07:24 UTC
Karolin,

Please select for the next 4.11, 4.12 and 4.13 releases.

Thanks!
Comment 5 Karolin Seeger 2020-08-06 11:29:30 UTC
(In reply to Andrew Bartlett from comment #4)
Pushed to autobuild-v4-{13,12,11}-test.
Comment 6 Karolin Seeger 2020-08-11 07:22:45 UTC
(In reply to Karolin Seeger from comment #5)
Pushed to all branches.
Closing out bug report.

Thanks!