Bug 14437 - vfs snapper build option implemented inconsistently
Summary: vfs snapper build option implemented inconsistently
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.13.0.rc1
Hardware: All All
: P5 normal (vote)
Target Milestone: 4.13
Assignee: David Disseldorp
QA Contact: Samba QA Contact
Depends on:
Reported: 2020-07-10 10:29 UTC by Björn Jacke
Modified: 2020-09-18 08:34 UTC (History)
2 users (show)

See Also:

cherry-pick for v4-13-test (4.53 KB, patch)
2020-09-03 12:55 UTC, David Disseldorp
bjacke: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2020-07-10 10:29:12 UTC
vfs snapper is being tried to be built by default. If this is not possible then it says that you can do:

vfs_snapper is enabled but prerequisite DBUS libraries or headers not found. Use --disable-snapper to disable vfs_snapper support.
(complete log in /home/samba/v4-13/bin/config.log)

But the right way to disable a vfs module is the configure option --with-shared-modules=!vfs_snapper - if you use that configre option, then the configure check still fails with above message.

The option --disable-snapper needs to be removed and the standard "!modulename" method needs to be fixed for vfs_snapper before 4.13.0
Comment 1 Björn Jacke 2020-07-10 11:00:11 UTC
this boild down do revert the commit, that introduced all this:

commit 7ae03a19b3ca895ba5f97a6bd4f9539d8daa6e0a
Author: Matt Taylor <liverbugg@rinux.org>
Date:   Mon May 11 15:26:41 2020 -0400

    build: add configure option to control vfs_snapper build
    vfs_snapper is currently built if dbus development headers / libraries
    are detected during configure. This commit adds new --disable-snapper
    and --enable-snapper (default) configure parameters. When enabled,
    configure will fail if the dbus development headers / libraries are
    Signed-off-by: Matt Taylor <liverbugg@rinux.org>
    Reviewed-by: David Disseldorp <ddiss@samba.org>
    Reviewed-by: Andrew Bartlett <abartlet@samba.org>

With that reverted, we get the intended consistency.
Comment 2 David Disseldorp 2020-07-29 16:02:33 UTC
This bug has been discussed on the mailing list:

The current plan is to fix --with-shared-modules=!vfs_snapper behaviour and drop --disable-snapper/--enable-snapper, while avoiding the reintroduction of "automagic" configure functionality. I'll try to get around to this later this week.
Comment 3 Björn Jacke 2020-07-29 20:16:35 UTC
I don't have the oportunity to participate in that discussion within the next two weeks. For now I can say that I i object to make more options force enabled (not auto-enabled) by default unless the specific feature is available on all platforms (Lunux, FreeBSD, AIX and Solaris) also.
Comment 4 David Disseldorp 2020-09-03 12:55:47 UTC
Created attachment 16197 [details]
cherry-pick for v4-13-test
Comment 5 Samba QA Contact 2020-09-04 12:38:06 UTC
This bug was referenced in samba v4-13-test:
Comment 6 Karolin Seeger 2020-09-07 10:32:05 UTC
Pushed to v4-13-test.
Re-assigning to David as there might be another longterm fix.
Comment 7 David Disseldorp 2020-09-07 12:06:27 UTC
(In reply to Karolin Seeger from comment #6)
> Pushed to v4-13-test.


> Re-assigning to David as there might be another longterm fix.

I don't plan on making any changes to the fix now in master. Please reopen if something comes up. Closing...
Comment 8 Samba QA Contact 2020-09-18 08:34:17 UTC
This bug was referenced in samba v4-13-stable: