Bug 14422 - build failure in test_util_paths.c
Summary: build failure in test_util_paths.c
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.10.16
Hardware: All All
: P5 regression (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-29 12:24 UTC by Björn Jacke
Modified: 2020-09-18 12:22 UTC (History)
1 user (show)

See Also:

Attachments
cherry-picked patch for 4.10, 4.11 and 4.12 (1.03 KB, patch)
2020-06-29 18:40 UTC, Björn Jacke 		slow: review+
bjacke: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2020-06-29 12:24:05 UTC 
replace.h should always be included early to avoid build errors due to redefines
Comment 1 Björn Jacke 2020-06-29 18:33:16 UTC 
This is fixed in master with d93a6d2663a25bca072cd5623aea16e21ed650b8

It would be nice to get this into 4.10 (4.10.16 has this regression is already). For 4.11 and 4.12 this is required for the currenct test branches also. If this is too late for the next release it's not a big deal, I think only AIX is affected here.
Comment 2 Björn Jacke 2020-06-29 18:40:02 UTC 
Created attachment 16098 [details]
cherry-picked patch for 4.10, 4.11 and 4.12
Comment 3 Karolin Seeger 2020-07-03 09:39:52 UTC 
(In reply to Björn Jacke from comment #2)
Pushed to autobuild-v4-{10,11,12}-test.
Comment 4 Karolin Seeger 2020-07-09 07:34:28 UTC 
(In reply to Karolin Seeger from comment #3)
Pushed to all branches.
Closing out bug report.

Thanks!
Comment 5 Samba QA Contact 2020-09-18 11:51:49 UTC 
This bug was referenced in samba v4-10-stable:

40d23ea50ce8c44283c41c4cb66b12189f836007
Comment 6 Samba QA Contact 2020-09-18 12:22:53 UTC 
This bug was referenced in samba v4-10-stable (Release samba-4.10.18):

40d23ea50ce8c44283c41c4cb66b12189f836007