Bug 14415 - Fix build on FreeBSD (regression in Samba 4.10.16)
Summary: Fix build on FreeBSD (regression in Samba 4.10.16)
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
Depends on:
Reported: 2020-06-19 11:30 UTC by Andrew Walker
Modified: 2020-07-09 07:33 UTC (History)
2 users (show)

See Also:

required cherry-picked patches for 4-10-test from master (5.13 KB, patch)
2020-06-29 12:17 UTC, Björn Jacke
slow: review+
bjacke: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Walker 2020-06-19 11:30:43 UTC
Compilation on FreeBSD fails with following error:

../../lib/util/util_paths.c:71:11: error: use of undeclared identifier 'NSS_BUFLEN_PASSWD'
        char buf[NSS_BUFLEN_PASSWD] = {0};
../../lib/util/util_paths.c:74:39: error: use of undeclared identifier 'NSS_BUFLEN_PASSWD'
        rc = getpwuid_r(getuid(), &pwd, buf, NSS_BUFLEN_PASSWD, &pwdbuf);
2 errors generated.

Regression caused by commit: 452e543ca5fa31a8a6bc72489e129567ff65c7b7
Comment 1 Andrew Walker 2020-06-19 11:59:24 UTC
Merge request in gitlab: https://gitlab.com/samba-team/samba/-/merge_requests/1406
Comment 2 Ralph Böhme 2020-06-19 12:22:49 UTC
For the backports we need all three commits from 

Comment 3 Björn Jacke 2020-06-29 12:17:27 UTC
Created attachment 16097 [details]
required cherry-picked patches for 4-10-test from master
Comment 4 Björn Jacke 2020-06-29 17:06:58 UTC
(In reply to Björn Jacke from comment #3)
these are also required for the current v4-11-test and v4-12-test branches, Ralph also tested the build for those branches.
Comment 5 Karolin Seeger 2020-07-03 09:37:57 UTC
Pushed to autobuild-v4-{12,11,10}-test.
Comment 6 Karolin Seeger 2020-07-09 07:33:33 UTC
(In reply to Karolin Seeger from comment #5)
Pushed to all branches.
Closing out bug report.