Bug 14409 - vfs_fruit: fruit:time machine max size does not report disk size. Latest macOS switched from .sparsebundle to .backupbundle
Summary: vfs_fruit: fruit:time machine max size does not report disk size. Latest macO...
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 4.10.15
Hardware: All Linux
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-16 05:54 UTC by Moritz
Modified: 2020-06-16 05:54 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Moritz 2020-06-16 05:54:49 UTC 
Limiting the reported disksize for Time Machine does not work with new "backupbundle"

macOS 10.5 (Catalina) started to use ".backupbundle" instead of ".sparsebundle" for Time Machine backups. Thus the calculation via "fruit:time machine max size" does not work anymore. 

When creating a symlink directly in the volume path. For instance "ln -s file.backupbundle file.sparsebundle“ calculation is working again. 

So I guess that a simple extension of the search string from just "sparsebundle" to "sparsebundle" OR "backupbundle" should be enough vfs_fruit.c

But I think it's in this line: <https://github.com/samba-team/samba/blob/c68133d41c368c52cd5ac3c34dbe888ceccd7619/source3/modules/vfs_fruit.c#L4909>