Bug 14387 - use of zero length array in libcli/ldap/tests/ldap_message_test.c
Summary: use of zero length array in libcli/ldap/tests/ldap_message_test.c
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.11.9
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-19 14:52 UTC by Björn Jacke
Modified: 2020-06-25 07:17 UTC (History)
1 user (show)

See Also:

Attachments
Proposed patch for master V1 (1.07 KB, patch)
2020-06-22 21:00 UTC, Gary Lockyer 		bjacke: review+
gary: ci-passed+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2020-05-19 14:52:04 UTC 
libcli/ldap/tests/ldap_message_test.c defines a zero length array (uint8_t buf[0]), which is not allowed in C and breaks the build with some strict compilers like xlc.
Comment 1 Gary Lockyer 2020-06-22 21:00:23 UTC 
Created attachment 16063 [details]
Proposed patch for master V1

MR: https://gitlab.com/samba-team/samba/-/merge_requests/1415
Comment 2 Björn Jacke 2020-06-23 09:40:38 UTC 
Comment on attachment 16063 [details]
Proposed patch for master V1

review+ for a cherry-pick -x d701bc1518766f36b1c7a3a00a82485098a8ee3d to 4.12
Comment 3 Karolin Seeger 2020-06-24 09:53:05 UTC 
Pushed to autobuild-v4-12-test.
Comment 4 Karolin Seeger 2020-06-25 07:17:35 UTC 
(In reply to Karolin Seeger from comment #3)
Pushed to v4-12-test.
Closing out bug report.

Thanks!