Bug 14375 - Windows 7 clients problem after upgrading samba file server
Summary: Windows 7 clients problem after upgrading samba file server
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.12.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-11 07:55 UTC by Ralph Böhme
Modified: 2020-05-17 05:19 UTC (History)
2 users (show)

See Also:

Attachments
WIP patch for master (1.76 KB, patch)
2020-05-11 07:55 UTC, Ralph Böhme 		no flags Details
git-am fix for 4.12.next (11.74 KB, patch)
2020-05-12 20:55 UTC, Jeremy Allison 		slow: review+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Böhme 2020-05-11 07:55:03 UTC 
Created attachment 15966 [details]
WIP patch for master

https://lists.samba.org/archive/samba/2020-May/229548.html
https://lists.samba.org/archive/samba/2020-May/229662.html

There are more...

Triggered by a specific series of SMB2 CREATEs, the first one being a stat-open with share "none", subsequently Samba 4.12 fails CREATES with NT_STATUS_SHARING_VIOLATION.

Have (WIP) patch, need bugnumber...
Comment 1 Jeremy Allison 2020-05-11 18:17:43 UTC 
Ping. Let me know when you're ready for review. I feel bad about the original problem so I'd like to help review the fix :-).
Comment 2 Andrew Bartlett 2020-05-12 09:37:49 UTC 
Make sure to credit the reporter, they also did a lot of work for this (assuming they give permission, I've asked).
Comment 3 Ralph Böhme 2020-05-12 14:59:23 UTC 
Jeremy, final patchset is here:

https://gitlab.com/samba-team/samba/-/merge_requests/1334

Already reviewed by Volker, I'm going to push later on...
Comment 4 Jeremy Allison 2020-05-12 20:55:29 UTC 
Created attachment 15975 [details]
git-am fix for 4.12.next

Cherry-picked from master. Do we need this for 4.11 (I didn't think so).
Comment 5 Ralph Böhme 2020-05-13 10:07:19 UTC 
Ressigning to Karolin for inclusion in 4.12.
Comment 6 Karolin Seeger 2020-05-14 07:10:23 UTC 
(In reply to Ralph Böhme from comment #5)
Pushed to autobuild-v4-12-test.
Comment 7 Karolin Seeger 2020-05-17 05:19:24 UTC 
(In reply to Karolin Seeger from comment #6)
Pushed to v4-12-test.
Closing out bug report.

Thanks!