The Samba-Bugzilla – Bug 1432
Arg array for rsync-daemon globbing only holds 1000 entries
Last modified: 2005-04-01 11:24:09 UTC
Alan Burlison wrote:
rsync: connection unexpectedly closed (1598 bytes read so far)
rsync error: error in rsync protocol data stream (code 12) at io.c(165)
This is because the array used to hold the expanded filename glob (argv in
rsync_module(), clientserver.c) is only 1000 entries in size, and the above
archive directory contains more than 1000 files. argv should probably be
allocated with malloc and grown as necessary with realloc.
Created attachment 536 [details]
Make argv list dynamically allocated
Alan Burlison's suggested fix.
My version of the patch is here:
It was updated to work with CVS, to fix a bug in one of the realloc() calls, and
to neaten a few things up.
Patch checked into CVS.