Bug 14317 - Add support for compiling cwrap/resolv_wrapper on Mac OS X
Summary: Add support for compiling cwrap/resolv_wrapper on Mac OS X
Status: NEW
Alias: None
Product: cwrap
Classification: Unclassified
Component: library (show other bugs)
Version: unspecified
Hardware: All Mac OS X
: P5 enhancement
Target Milestone: ---
Assignee: Andreas Schneider
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-09 13:14 UTC by Max Englander
Modified: 2020-04-01 05:48 UTC (History)
0 users

See Also:

Attachments
Mac OS compatibility patch (10.71 KB, application/mbox)
2020-03-09 13:14 UTC, Max Englander 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Englander 2020-03-09 13:14:24 UTC 
Created attachment 15851 [details]
Mac OS compatibility patch

Hello Cwrap team:

Thank you for the great tool! I would like to be able to use this tool on Mac OS X, so I have made some minor changes to allow for that.

I've tested these changes on my computer, which is a circa-2015 MacBook Pro, running Sierra 10.12.6.

Let me know if you'd like me to made any changes to the patch.

Separately, I've noticed that the most recent resolv_wrapper tarball is from 2016, but there are commits in the git repository from 2020. Are there more recent tarballs available somewhere, or is the best place to get up-to-date changes git?

Cheers,
Max
Comment 1 Andreas Schneider 2020-04-01 05:48:56 UTC 
Hi Max,

thanks you very much for your contribution. There should be resolv_wrapper-1.1.6.tar.gz packages available. Please check again.

Could you please split up your patch into smaller patches and submit a Merge Request at:

https://gitlab.com/cwrap/resolv_wrapper

This will run CI for us and make sure we didn't break anything.


Thanks!