Bug 14316 - Using vfs_fruit alongside with vfs_recycle
Summary: Using vfs_fruit alongside with vfs_recycle
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-06 11:47 UTC by Isaac Boukris
Modified: 2020-03-19 09:41 UTC (History)
1 user (show)

See Also:


Attachments
log level 10 from my lab (1.73 MB, text/plain)
2020-03-06 12:27 UTC, Isaac Boukris
no flags Details
patch of 4.11 branch (1.36 KB, patch)
2020-03-12 08:40 UTC, Isaac Boukris
iboukris: review+
asn: review+
Details
patch for 4.12 branch (1.36 KB, patch)
2020-03-12 08:41 UTC, Isaac Boukris
iboukris: review+
asn: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Isaac Boukris 2020-03-06 11:47:32 UTC
See also: https://bugzilla.redhat.com/show_bug.cgi?id=1780802

With the following combination:
vfs objects = catia fruit streams_xattr recycle 

An error log appears upon deleting a file, failing to find '._filename':

[2020/03/06 12:28:48.627691,  0]
../../source3/modules/vfs_recycle.c:239(recycle_get_file_size)
  recycle: stat for ./._test.txt returned No such file or directory


Level 10 debug:

[2020/03/05 12:32:58.843553, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=fruit] ../source3/modules/vfs_fruit.c:4765(fruit_stat)
  fruit_stat called for temp/example.txt
[2020/03/05 12:32:58.843572, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=fruit] ../source3/modules/vfs_fruit.c:5368(fruit_streaminfo)
  fruit_streaminfo: Path [temp/example.txt]
[2020/03/05 12:32:58.843600, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=fruit] ../source3/modules/vfs_fruit.c:4765(fruit_stat)
  fruit_stat called for temp/example.txt
[2020/03/05 12:32:58.843614, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=fruit] ../source3/modules/vfs_fruit.c:4765(fruit_stat)
  fruit_stat called for temp/example.txt
[2020/03/05 12:32:58.843632, 10, pid=54521, effective(1002, 1001), real(1002, 0)] ../source3/smbd/trans2.c:326(get_ea_names_from_file)
  get_ea_names_from_file: ea_namelist size = 15
[2020/03/05 12:32:58.843648, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=fruit] ../source3/modules/vfs_fruit.c:4765(fruit_stat)
  fruit_stat called for temp/example.txt
[2020/03/05 12:32:58.843662, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=fruit] ../source3/modules/vfs_fruit.c:1669(ad_get_internal)
  ad_get(rsrc) called for temp/example.txt
[2020/03/05 12:32:58.843675, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=fruit] ../source3/modules/vfs_fruit.c:1259(ad_open)
  ad_open: Path [temp/example.txt] type [rsrc]
[2020/03/05 12:32:58.843690, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=fruit] ../source3/modules/vfs_fruit.c:1687(ad_get_internal)
  ad_get_internal: ad_open [temp/example.txt] error [No such file or directory]
[2020/03/05 12:32:58.843709, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=fruit] ../source3/modules/vfs_fruit.c:1703(ad_get_internal)
  ad_get(rsrc) for temp/example.txt returning -1
[2020/03/05 12:32:58.843723, 10, pid=54521, effective(1002, 1001), real(1002, 0)] ../source3/smbd/close.c:190(delete_all_streams)
  delete_all_streams found 1 streams
[2020/03/05 12:32:58.843750, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:47(recycle_repository)
  recycle: repository = @RecycleBin
[2020/03/05 12:32:58.843767, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=fruit] ../source3/modules/vfs_fruit.c:4765(fruit_stat)
  fruit_stat called for temp/._example.txt
[2020/03/05 12:32:58.843780,  0, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:243(recycle_get_file_size)
  recycle: stat for temp/._example.txt returned No such file or directory
[2020/03/05 12:32:58.843851, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:136(recycle_maxsize)
  recycle: maxsize = 0
[2020/03/05 12:32:58.843865, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:148(recycle_minsize)
  recycle: minsize = 1
[2020/03/05 12:32:58.843876,  3, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:515(recycle_unlink)
  recycle: File temp/._example.txt lowers minimum recycle size, purging...
[2020/03/05 12:32:58.843893, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:47(recycle_repository)
  recycle: repository = @RecycleBin
[2020/03/05 12:32:58.843908, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=fruit] ../source3/modules/vfs_fruit.c:4765(fruit_stat)
  fruit_stat called for temp/example.txt
[2020/03/05 12:32:58.843923, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:136(recycle_maxsize)
  recycle: maxsize = 0
[2020/03/05 12:32:58.843935, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:148(recycle_minsize)
  recycle: minsize = 1
[2020/03/05 12:32:58.843947, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:547(recycle_unlink)
  recycle: fname = temp/example.txt
[2020/03/05 12:32:58.843959, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:549(recycle_unlink)
  recycle: fpath = temp
[2020/03/05 12:32:58.843970, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:551(recycle_unlink)
  recycle: base = example.txt
[2020/03/05 12:32:58.843999, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:102(recycle_exclude)
  recycle: exclude = *.tmp ...

[2020/03/05 12:32:58.844029, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:113(recycle_exclude_dir)
  recycle: exclude_dir =  ...
[2020/03/05 12:32:58.844043, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:58(recycle_keep_dir_tree)
  recycle_bin: keeptree = True
[2020/03/05 12:32:58.844056, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=fruit] ../source3/modules/vfs_fruit.c:4765(fruit_stat)
  fruit_stat called for @RecycleBin/temp
[2020/03/05 12:32:58.844086, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:576(recycle_unlink)
  recycle: Directory already exists
[2020/03/05 12:32:58.844099, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:605(recycle_unlink)
  recycle: recycled file name: @RecycleBin/temp/example.txt
[2020/03/05 12:32:58.844116, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=fruit] ../source3/modules/vfs_fruit.c:4765(fruit_stat)
  fruit_stat called for @RecycleBin/temp/example.txt
[2020/03/05 12:32:58.844137, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=fruit] ../source3/modules/vfs_fruit.c:4765(fruit_stat)
  fruit_stat called for @RecycleBin/temp/example.txt
[2020/03/05 12:32:58.844160, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:636(recycle_unlink)
  recycle: Moving temp/example.txt to @RecycleBin/temp/example.txt
[2020/03/05 12:32:58.844219, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:80(recycle_touch)
  recycle: touch = True
[2020/03/05 12:32:58.844251, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=recycle] ../source3/modules/vfs_recycle.c:91(recycle_touch_mtime)
  recycle: touch_mtime = False
[2020/03/05 12:32:58.844265, 10, pid=54521, effective(1002, 1001), real(1002, 0), class=fruit] ../source3/modules/vfs_fruit.c:4765(fruit_stat)
  fruit_stat called for @RecycleBin/temp/example.txt
Comment 1 Isaac Boukris 2020-03-06 12:27:56 UTC
Created attachment 15845 [details]
log level 10 from my lab

level 10 log.smbd from my lab
Comment 2 Isaac Boukris 2020-03-12 08:40:33 UTC
Created attachment 15856 [details]
patch of 4.11 branch
Comment 3 Isaac Boukris 2020-03-12 08:41:37 UTC
Created attachment 15857 [details]
patch for 4.12 branch
Comment 4 Andreas Schneider 2020-03-12 10:49:35 UTC
Karolin, please add the patches to the relevant branches. Thanks :-)
Comment 5 Karolin Seeger 2020-03-18 10:26:33 UTC
(In reply to Andreas Schneider from comment #4)
Pushed to autobuild-v4-{12,11}-test.
Comment 6 Isaac Boukris 2020-03-18 17:29:23 UTC
Thanks!
Comment 7 Karolin Seeger 2020-03-19 09:41:59 UTC
(In reply to Karolin Seeger from comment #5)
Pushed to both branches.
Closing out bug report.

Thanks!