Bug 14296 - samba-tool group commands do not handle group names with special chars correctly
Summary: samba-tool group commands do not handle group names with special chars correctly
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Tools (show other bugs)
Version: 4.12.0rc4
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-26 13:35 UTC by Björn Baumbach
Modified: 2020-03-30 08:04 UTC (History)
1 user (show)

See Also:


Attachments
backported patch for 4.12 (12.82 KB, patch)
2020-03-02 11:07 UTC, Björn Baumbach
abartlet: review+
bbaumbach: ci-passed+
Details
backported patch for 4.11 (12.04 KB, patch)
2020-03-02 11:08 UTC, Björn Baumbach
abartlet: review+
bbaumbach: ci-passed+
Details
backported patch for 4.10 (10.78 KB, patch)
2020-03-02 11:09 UTC, Björn Baumbach
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Baumbach 2020-02-26 13:35:14 UTC
Example:

Creating a group with brackets in its name works:

# samba-tool group add 'samba (R)'
Added group samba (R)

But the delete command does not find the group by its name:

# samba-tool group delete 'samba (R)'
ERROR: Unable to find group "samba (R)"

Other commands like listmembers are also affected.

I already have a patch set and need a bug number, now.
Comment 1 Björn Baumbach 2020-02-27 10:44:53 UTC
Merge Request:
https://gitlab.com/samba-team/samba/-/merge_requests/1164
Comment 2 Björn Baumbach 2020-03-02 11:07:57 UTC
Created attachment 15834 [details]
backported patch for 4.12
Comment 3 Björn Baumbach 2020-03-02 11:08:45 UTC
Created attachment 15835 [details]
backported patch for 4.11
Comment 4 Björn Baumbach 2020-03-02 11:09:28 UTC
Comment on attachment 15835 [details]
backported patch for 4.11

CI for 4.11 passed:
https://gitlab.com/samba-team/devel/samba/pipelines/121899399
Comment 5 Björn Baumbach 2020-03-02 11:09:59 UTC
Created attachment 15836 [details]
backported patch for 4.10
Comment 6 Björn Baumbach 2020-03-13 11:18:39 UTC
Comment on attachment 15834 [details]
backported patch for 4.12

CI for 4.12 passed:
https://gitlab.com/samba-team/devel/samba/pipelines/123524348
Comment 7 Björn Baumbach 2020-03-26 14:54:05 UTC
Comment on attachment 15836 [details]
backported patch for 4.10

Last Samba 4.10 bugfix release was today. Marked patch as obsolete.
Comment 8 Andrew Bartlett 2020-03-26 17:55:24 UTC
(In reply to Björn Baumbach from comment #7)
You don't need to mark the patch as obsolete because the last release has been made, someone still running that version might want to select the patch regardless for their local installation.

I'm sorry for missing the review on the others, I'll add them in a moment.
Comment 9 Karolin Seeger 2020-03-27 09:14:37 UTC
Pushed to autobuild-v4-{12,11}-test.
Comment 10 Karolin Seeger 2020-03-30 08:04:25 UTC
(In reply to Karolin Seeger from comment #9)
Pushed to both branches.
Closing out bug report.

Thanks!