Bug 14290 - OmniOS compilation error about "s_addr" in lib/tsocket/tsocket.h & tsocket_bsd.c
Summary: OmniOS compilation error about "s_addr" in lib/tsocket/tsocket.h & tsocket_bsd.c
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other (show other bugs)
Version: 4.12.0rc3
Hardware: All Other
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-21 22:00 UTC by Peter Eriksson
Modified: 2021-03-17 09:53 UTC (History)
0 users

See Also:

Attachments
Patch to fix s_addr compilation error on OmniOS (1.86 KB, text/plain)
2020-02-21 22:00 UTC, Peter Eriksson 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Eriksson 2020-02-21 22:00:05 UTC 
Created attachment 15814 [details]
Patch to fix s_addr compilation error on OmniOS

OmniOS has a system-defined #define s_addr that causes compilation errors.

The attached patch fixes this by renaming a couple of function arguments from s_addr to xs_addr.
Comment 1 Peter Eriksson 2021-03-17 09:53:22 UTC 
Seems to have been fixed (not an issue in 4.14.0), so closing this.