Bug 14284 - 4.12 pidl configure should insist on Parse::Yapp::Driver
Summary: 4.12 pidl configure should insist on Parse::Yapp::Driver
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-19 20:40 UTC by Douglas Bagnall
Modified: 2020-02-24 08:18 UTC (History)
1 user (show)

See Also:


Attachments
backported patch (1.82 KB, patch)
2020-02-19 20:43 UTC, Douglas Bagnall
abartlet: review-
Details
patch including "build: Do not check if system perl modules should be bundled" (4.22 KB, patch)
2020-02-19 20:59 UTC, Douglas Bagnall
abartlet: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Douglas Bagnall 2020-02-19 20:40:39 UTC
On #samba-technical:

01:16 < Milhouse> Is it possible to avoid the perl errors with 4.12-rc3? http://ix.io/2c8i
01:17 < Milhouse> We don't have this perl issue when building 4.11.6 so presumably the pidl code isn't always used when 
                  building 4.11.6 (perhaps it's now being built incorrectly by 4.12-rc?)
01:25 < Milhouse> Or maybe this commit is relevant: 
                  https://github.com/samba-team/samba/commit/83ffe6752d589180eac96d7b8e7d1a54e3476bfd - hmmm, no longer 
                  supplied so this is a new dependency.
09:32 < dbagnall> Milhouse: you probably need commit af47a77673f58cc6436798b250c90be0e325d20e
09:32 < dbagnall> https://github.com/samba-team/samba/commit/af47a77673f58cc6436798b250c90be0e325d20e

This was fixed in master a few days ago but not in 4.12.
Comment 1 Douglas Bagnall 2020-02-19 20:43:08 UTC
Created attachment 15799 [details]
backported patch
Comment 2 Andrew Bartlett 2020-02-19 20:51:41 UTC
Comment on attachment 15799 [details]
backported patch

We need cf4984947b39e9f6f8afd29de8a760703bf9e092 also
Comment 3 Douglas Bagnall 2020-02-19 20:59:05 UTC
Created attachment 15800 [details]
patch including "build: Do not check if system perl modules should be bundled"
Comment 4 Andrew Bartlett 2020-02-19 21:25:35 UTC
Comment on attachment 15800 [details]
patch including "build: Do not check if system perl modules should be bundled"

Looking better.
Comment 5 Karolin Seeger 2020-02-20 10:31:43 UTC
(In reply to Andrew Bartlett from comment #4)
Pushed to autobuild-v4-12-test.
Comment 6 Karolin Seeger 2020-02-24 08:18:09 UTC
(In reply to Karolin Seeger from comment #5)
Pushed to v4-12-test.
Closing out bug report.

Thanks!