Bug 14278 - default statement missing
Summary: default statement missing
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: smbtorture (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-13 10:34 UTC by Amit Kumar
Modified: 2020-02-13 10:34 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Amit Kumar 2020-02-13 10:34:49 UTC 
samlogon.c

inside function static NTSTATUS check_samlogon()

a.
		switch (validation_level) {
		case 2:
			base = &r_flags->out.validation->sam2->base;
			break;
		case 3:
			base = &r_flags->out.validation->sam3->base;
			break;
		case 6:
			base = &r_flags->out.validation->sam6->base;
			break;
		}
		break;
	default:

b. Also, its nested switches.. looks bad. Can we design better?