Bug 14248 - samba process does not honor max log size
Summary: samba process does not honor max log size
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other (show other bugs)
Version: 4.11.4
Hardware: All All
: P5 normal with 1 vote (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-24 13:15 UTC by Björn Jacke
Modified: 2021-01-15 00:28 UTC (History)
4 users (show)

See Also:

Attachments
Patch for 4.12 backported from master (23.13 KB, patch)
2020-12-08 15:08 UTC, Ralph Böhme 		jra: review+
Details
Patch for 4.13 backported from master (23.09 KB, patch)
2020-12-08 15:09 UTC, Ralph Böhme 		jra: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2020-01-24 13:15:43 UTC 
log.samba only grows and is never rotated or truncated. The samba DC does obviously  not honor max log size at all

(Is it possible that this is still not implemented and we still don't even have a bug report for this???)
Comment 1 Ralph Böhme 2020-01-24 13:50:44 UTC 
This may be related to another missing feature which is seperate logfile per service. I have WIP patches for this somewhere...
Comment 2 Samba QA Contact 2020-12-07 18:55:04 UTC 
This bug was referenced in samba master:

ab2c712c016f4e4dacd5064b9eb8f6417f4b9b60
29cd139a32d5dbf36bef68eb9c7f1160201e3042
b7ee36146458bcc2c944f5670b7632df8281ae61
3651a51e93b45104323d5db1d5ea704d4f71acf1
68f71f227b17774a12c84575c1eecd82279fac95
516c2a04a242a539f9fbddb2822295fee233644c
9f71e6173ab43a04804ba8061cb0e8ae6c0165bf
19413e76a46f07fdd46fde5e60707bb6845a782d
82b64e930b0e2d3b2e5186017d9f8e420994136c
6fa5fb8ef26dab862df5c46bb5e74f19839c30e2
058f96f4c4eda42b404f0067521d3eafb495fe7d
Comment 3 Ralph Böhme 2020-12-08 15:08:31 UTC 
Created attachment 16362 [details]
Patch for 4.12 backported from master
Comment 4 Ralph Böhme 2020-12-08 15:09:29 UTC 
Created attachment 16363 [details]
Patch for 4.13 backported from master
Comment 5 Jeremy Allison 2020-12-08 19:09:38 UTC 
Re-assigning to Karolin for inclusion in 4.13.next, 4.12.next.
Comment 6 Karolin Seeger 2020-12-09 07:51:56 UTC 
(In reply to Jeremy Allison from comment #5)
Pushed to autobuild-v4-{13,12}-test.
Comment 7 Samba QA Contact 2020-12-09 08:57:04 UTC 
This bug was referenced in samba v4-13-test:

99ea8cd6dfa2ce30461e9bc9def18e9df6e8bf9f
39efb02c6b49fac0775b9011f82db9d71f6f101f
e7df21ac6408ddde3993bde03b15483db01066a7
80401025504de3c24209f354494b03f95d56ece2
69a8fb4f971a87fcb70607fdf4827f64fd806964
504c6e03018038aef0fa4753b9e0f315307f4ad1
fa2ea13ec04c09d1748aad41b27bbcb0c8e056f8
7258fc076adab75d3abeaa874159eb5b04ee5f23
f89daf8d25585a22470dfe4ca04157421f8e93cf
db202fc3efc104bb9ded33931759e506f0523d25
e3d6d452118389dedbd64f22a2e1f167d24dd45f
Comment 8 Samba QA Contact 2020-12-09 11:46:04 UTC 
This bug was referenced in samba v4-12-test:

ccf971eef5c780031915fc61bf6bc1ffeb24e73d
f6bd782cb3b68354c6ebe1bae7fd82f4c5f5fb1f
5cd1e3c5a4aade5d589ad7df613766e0cb38f342
6c881025bfa45927076e1b995bf948f0434417ae
5b838f5075c856779a38d9a2a023bf1b33cb1afd
7299ebb1215776b19f5094e861a21c7df06220f2
1a6f2871036f5271aefa63f745e691a38684b40e
b50ef6fa897b2c007e17a0ccb38e04bdeb7cec00
4e6fdf5d8d932af52f029f84da774ae920e3a80f
91f2f2dedb7e9fcac1ebc4849b5e64056905849a
20480f70ce0608a1bf296eda8f9dbff8cf746078
Comment 9 Karolin Seeger 2020-12-09 13:16:08 UTC 
Pushed to both branches.
Closing out bug report.

Thanks!
Comment 10 Samba QA Contact 2020-12-16 12:22:08 UTC 
This bug was referenced in samba v4-13-stable (Release samba-4.13.3):

99ea8cd6dfa2ce30461e9bc9def18e9df6e8bf9f
39efb02c6b49fac0775b9011f82db9d71f6f101f
e7df21ac6408ddde3993bde03b15483db01066a7
80401025504de3c24209f354494b03f95d56ece2
69a8fb4f971a87fcb70607fdf4827f64fd806964
504c6e03018038aef0fa4753b9e0f315307f4ad1
fa2ea13ec04c09d1748aad41b27bbcb0c8e056f8
7258fc076adab75d3abeaa874159eb5b04ee5f23
f89daf8d25585a22470dfe4ca04157421f8e93cf
db202fc3efc104bb9ded33931759e506f0523d25
e3d6d452118389dedbd64f22a2e1f167d24dd45f
Comment 11 Samba QA Contact 2021-01-14 08:33:37 UTC 
This bug was referenced in samba v4-12-stable (Release samba-4.12.11):

ccf971eef5c780031915fc61bf6bc1ffeb24e73d
f6bd782cb3b68354c6ebe1bae7fd82f4c5f5fb1f
5cd1e3c5a4aade5d589ad7df613766e0cb38f342
6c881025bfa45927076e1b995bf948f0434417ae
5b838f5075c856779a38d9a2a023bf1b33cb1afd
7299ebb1215776b19f5094e861a21c7df06220f2
1a6f2871036f5271aefa63f745e691a38684b40e
b50ef6fa897b2c007e17a0ccb38e04bdeb7cec00
4e6fdf5d8d932af52f029f84da774ae920e3a80f
91f2f2dedb7e9fcac1ebc4849b5e64056905849a
20480f70ce0608a1bf296eda8f9dbff8cf746078