The waf update in Samba 4.10 broke the build with the configure option --with-system-heimdalkrb5 Patches to fix this to follow.
Created attachment 15617 [details] Patches for 4.10
Created attachment 15618 [details] Patches for 4.11
Comment on attachment 15617 [details] Patches for 4.10 Please add a bug number to the first patch. Does the new autobuild task operate on GitLab CI? We need to be able to use that platform for CI, particularly for security releases. If not, then please omit backporting the samba-test-heimdal task or at least remove it from the default set of tasks.
Comment on attachment 15618 [details] Patches for 4.11 Can you confirm this passes a GitLab CI and then tick ci-passed? I'm just nervous this could land via sn-devel but we would not not notice it breaking that until we need to run a GitLab CI in a hurry.
Comment on attachment 15618 [details] Patches for 4.11 gitlab CI succeeded for 4.11 backport: https://gitlab.com/samba-team/devel/samba/pipelines/95745972
Created attachment 15619 [details] Patches for 4.10
(In reply to Andrew Bartlett from comment #3) > Please add a bug number to the first patch. Done. > Does the new autobuild task operate on GitLab CI? We need to be able to use > that platform for CI, particularly for security releases. > > If not, then please omit backporting the samba-test-heimdal task or at least > remove it from the default set of tasks. My current understanding is that gitlab integration in 4.10 is limited and the image used does not have heimdal-dev installed, so this task won't work. On the other hand, it runs with script/autobuild.py and that succeeds on sn-devel-184. So we would have test coverage there. Is that sufficient?
(In reply to Christof Schmitt from comment #7) Sadly not. We need it to pass on both GitLab CI and sn-devel as while sn-devel is manually updated to roughly match our required packages in master, the old CI image isn't. We could update the Ubuntu 14.04 docker image at registry.gitlab.com/samba-team/samba:latest, but then we have to also check that 4.9 still builds. And I don't remember how exactly we built that image anyway. Also, the check on sn-devel needs to be on the sn-devel-144 Ubutu 14.04 container as I understand it. So, given all that, do we really, really need this backported to 4.10? Sorry!
(In reply to Andrew Bartlett from comment #8) > So, given all that, do we really, really need this backported to 4.10? For my use, the backport to 4.11 is sufficient. It would be nice to also fix this in 4.10 as the system heimdal build broke with 4.10.0, but based on your input that is not worth the trouble. I will cancel the patch. Are you good with the 4.11 backport that passed the CI run?
Comment on attachment 15618 [details] Patches for 4.11 Thanks.
Assigning to Karolin for 4.11 If we wanted to do it for 4.10 and there was demand it would need to go in untested I think, which isn't ideal but isn't impossible either. https://wiki.samba.org/index.php/Samba_Release_Planning#Maintenance_Mode describes what should go to 4.10 per our current practice.
Pushed to autobuild-v4-11-test.
(In reply to Karolin Seeger from comment #12) Pushed to v4-11-test. Closing out bug report. Thanks!