Bug 14179 - Build with heimdal system library broke with waf update in Samba 4.10
Summary: Build with heimdal system library broke with waf update in Samba 4.10
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.10.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-30 20:39 UTC by Christof Schmitt
Modified: 2019-11-25 11:10 UTC (History)
1 user (show)

See Also:


Attachments
Patches for 4.10 (18.99 KB, patch)
2019-11-13 21:30 UTC, Christof Schmitt
no flags Details
Patches for 4.11 (15.21 KB, patch)
2019-11-13 21:30 UTC, Christof Schmitt
abartlet: review+
cs: ci-passed+
Details
Patches for 4.10 (19.04 KB, patch)
2019-11-13 22:19 UTC, Christof Schmitt
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christof Schmitt 2019-10-30 20:39:29 UTC
The waf update in Samba 4.10 broke the build with the configure
option --with-system-heimdalkrb5

Patches to fix this to follow.
Comment 1 Christof Schmitt 2019-11-13 21:30:08 UTC
Created attachment 15617 [details]
Patches for 4.10
Comment 2 Christof Schmitt 2019-11-13 21:30:29 UTC
Created attachment 15618 [details]
Patches for 4.11
Comment 3 Andrew Bartlett 2019-11-13 21:36:32 UTC
Comment on attachment 15617 [details]
Patches for 4.10

Please add a bug number to the first patch.

Does the new autobuild task operate on GitLab CI?  We need to be able to use that platform for CI, particularly for security releases.

If not, then please omit backporting the samba-test-heimdal task or at least remove it from the default set of tasks.
Comment 4 Andrew Bartlett 2019-11-13 21:38:59 UTC
Comment on attachment 15618 [details]
Patches for 4.11

Can you confirm this passes a GitLab CI and then tick ci-passed?

I'm just nervous this could land via sn-devel but we would not not notice it breaking that until we need to run a GitLab CI in a hurry.
Comment 5 Christof Schmitt 2019-11-13 21:57:50 UTC
Comment on attachment 15618 [details]
Patches for 4.11

gitlab CI succeeded for 4.11 backport:
https://gitlab.com/samba-team/devel/samba/pipelines/95745972
Comment 6 Christof Schmitt 2019-11-13 22:19:34 UTC
Created attachment 15619 [details]
Patches for 4.10
Comment 7 Christof Schmitt 2019-11-13 22:22:38 UTC
(In reply to Andrew Bartlett from comment #3)
> Please add a bug number to the first patch.

Done.

> Does the new autobuild task operate on GitLab CI?  We need to be able to use
> that platform for CI, particularly for security releases.
>
> If not, then please omit backporting the samba-test-heimdal task or at least
> remove it from the default set of tasks.

My current understanding is that gitlab integration in 4.10 is limited
and the image used does not have heimdal-dev installed, so this task
won't work.

On the other hand, it runs with script/autobuild.py and that succeeds
on sn-devel-184. So we would have test coverage there. Is that sufficient?
Comment 8 Andrew Bartlett 2019-11-14 01:22:28 UTC
(In reply to Christof Schmitt from comment #7)
Sadly not.

We need it to pass on both GitLab CI and sn-devel as while sn-devel is manually updated to roughly match our required packages in master, the old CI image isn't.

We could update the Ubuntu 14.04 docker image at registry.gitlab.com/samba-team/samba:latest, but then we have to also check that 4.9 still builds.  And I don't remember how exactly we built that image anyway.

Also, the check on sn-devel needs to be on the sn-devel-144 Ubutu 14.04 container as I understand it. 

So, given all that, do we really, really need this backported to 4.10?

Sorry!
Comment 9 Christof Schmitt 2019-11-14 03:45:22 UTC
(In reply to Andrew Bartlett from comment #8)
> So, given all that, do we really, really need this backported to 4.10?

For my use, the backport to 4.11 is sufficient. It would be nice to
also fix this in 4.10 as the system heimdal build broke with 4.10.0,
but based on your input that is not worth the trouble. I will cancel
the patch. Are you good with the 4.11 backport that passed the CI run?
Comment 10 Andrew Bartlett 2019-11-14 03:50:10 UTC
Comment on attachment 15618 [details]
Patches for 4.11

Thanks.
Comment 11 Andrew Bartlett 2019-11-14 03:51:48 UTC
Assigning to Karolin for 4.11

If we wanted to do it for 4.10 and there was demand it would need to go in untested I think, which isn't ideal but isn't impossible either. 

https://wiki.samba.org/index.php/Samba_Release_Planning#Maintenance_Mode describes what should go to 4.10 per our current practice.
Comment 12 Karolin Seeger 2019-11-19 08:51:46 UTC
Pushed to autobuild-v4-11-test.
Comment 13 Karolin Seeger 2019-11-25 11:10:02 UTC
(In reply to Karolin Seeger from comment #12)
Pushed to v4-11-test.
Closing out bug report.

Thanks!