Bug 14178 - cli->raw_status isn't consistently handled in our client code paths.
Summary: cli->raw_status isn't consistently handled in our client code paths.
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: libsmbclient (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jeremy Allison
QA Contact: Samba QA Contact
Depends on:
Reported: 2019-10-30 18:13 UTC by Jeremy Allison
Modified: 2019-10-31 21:14 UTC (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2019-10-30 18:13:53 UTC
It's mostly handled correctly in the SMB2 code paths, but not at all consistently set in the SMB1 code paths.

libsmbclient depends on cli->raw_status being correct when calling SMBC_errno() to return a POSIX-style errno to the caller.
Comment 1 Jeremy Allison 2019-10-31 21:14:42 UTC
Ha ! Looked a *lot* closer, and it seems that cli->raw_status *is* being handled correctly in the SMB1 code paths (it's always being set, on success or fail to allow upper layers to look at the last SMB operation status code).

It turns out this isn't always being done in the *SMB2* code, not the SMB1 code, so the actual fix here should be (a) much smaller, and (b) in the SMB2 code, not the SMB1 code :-).