Bug 14148 - Samba doesn't implement FILE_NOTIFY_CHANGE_SECURITY
Summary: Samba doesn't implement FILE_NOTIFY_CHANGE_SECURITY
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba release manager
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-01 12:54 UTC by Ralph Böhme
Modified: 2026-06-23 10:49 UTC (History)
4 users (show)

See Also:

Attachments
Patch from master for v4-23-test (8.72 KB, patch)
2025-11-06 12:46 UTC, Guenther Deschner 		gd: review? (jra)
slow: review+
Details
Patch from master for v4-22-test (8.72 KB, patch)
2025-11-06 12:46 UTC, Guenther Deschner 		gd: review? (jra)
slow: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Böhme 2019-10-01 12:54:09 UTC 
Changing an ACL should generate a FILE_NOTIFY_CHANGE_SECURITY notification. Looks like the code to trigger this was never added to smbd.
Comment 1 Jeremy Allison 2019-10-01 16:42:37 UTC 
Oh good catch. Should be only one place that needs changing, set_sd() inside source3/smbd/nttrans.c.
Comment 2 Ralph Böhme 2019-10-01 16:45:16 UTC 
(In reply to Jeremy Allison from comment #1)
Yup. Plus some basic smoke tests.
Comment 3 Samba QA Contact 2025-11-06 02:43:03 UTC 
This bug was referenced in samba master:

29e51f3ed935d0475b1715f82560ee356ab5e401
2be7c0c2f927042843fb8a2ea0b9c67d1f969d00
Comment 4 Guenther Deschner 2025-11-06 12:46:03 UTC 
Created attachment 18770 [details]
Patch from master for v4-23-test
Comment 5 Guenther Deschner 2025-11-06 12:46:32 UTC 
Created attachment 18771 [details]
Patch from master for v4-22-test
Comment 6 Ralph Böhme 2026-06-23 07:11:24 UTC 
Reassigned to Björn for inclusion in 4.23 and 4.22.
Comment 7 Björn Jacke 2026-06-23 08:44:59 UTC 
pushed to 4.23, 4.24 doesn't need this, this was in master before 4.24 was splitt off.
Comment 8 Samba QA Contact 2026-06-23 09:53:03 UTC 
This bug was referenced in samba v4-23-test:

332434df101f7ccdb80e8a28703fe0ca9b483f1b
97ad39f81f4b85f0e01c67696af7ea684f57be97
Comment 9 Samba QA Contact 2026-06-23 10:49:42 UTC 
This bug was referenced in samba v4-23-stable (Release samba-4.23.9):

332434df101f7ccdb80e8a28703fe0ca9b483f1b
97ad39f81f4b85f0e01c67696af7ea684f57be97