Bug 14115 - vfs_recycle can't handle ._ AppleDouble files (vfs_fruit)
Summary: vfs_recycle can't handle ._ AppleDouble files (vfs_fruit)
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 4.9.1
Hardware: x64 Linux
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-04 10:54 UTC by LP
Modified: 2020-02-13 06:47 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description LP 2019-09-04 10:54:08 UTC
Hi,

My log files are being flooded with errors like the ones below whenever a Mac or Windows client delete files from a Samba share.

--- Mac client ---

[2019/07/26 14:02:26.182564,  0] ../source3/modules/vfs_recycle.c:243(recycle_get_file_size)
  recycle: stat for Chris_Mac/._videos.docx returned No such file or directory

[2019/07/26 14:02:27.186472,  0] ../source3/modules/vfs_recycle.c:243(recycle_get_file_size)
  recycle: stat for Chris_Mac/._Pollay.pdf returned No such file or directory

[2019/07/26 15:52:11.165328,  0] ../source3/modules/vfs_recycle.c:243(recycle_get_file_size)
  recycle: stat for temp/._checklist.pdf returned No such file or directory

--- Windows client ---

[2019/09/04 11:45:53.923258,  0] ../source3/modules/vfs_recycle.c:243(recycle_get_file_size)
  recycle: stat for LF/._Cent OS.one returned No such file or directory

I tried without success different options for fruit:metadata and fruit:resource. I've also researched the order of vfs modules and it seems I'm using them in the correct order.

I'm including the Global and Share sections of my SMB.CONF files below.

Regards,
LP

=======

Server CentOS 7.6
Samba Version 4.8.3
Filesystem EXT4

Client Mac OS 10.14.5

**** SMB.CONF ***

[global]
;       Most Windows systems default to WORKGROUP
        workgroup = WORKGROUP
        server string = Samba Server Version %v
        netbios name = PIXIES

        interfaces = lo 192.168.0.0/24
        hosts allow = 127. 192.168.0.
        hostname lookups = yes

        log file = /var/log/samba/samba.log.%m
        max log size = 50

        security = user
        passdb backend = tdbsam
        guest account = nobody
        load printers = no

        fruit:aapl = yes
        fruit:nfs_aces = no
        unix extensions = no

[User]
        comment = User Files
        path = /share/samba/user
        directory mask = 0775
        create mask = 0774
        force directory mode = 0775
        force create mode = 0774
        writable = yes
        browseable = yes
        guest ok = no
        write list = @home
        valid users = @home, macuser, pcuser

        veto files = /.AppleDB/.AppleDouble/.AppleDesktop/:2eDS_Store/Network Trash Folder/Temporary Items/TheVolumeSettingsFolder/.@__thumb/.@__desc/:2e*/.@__qini/.@upload_cache/.@qsys/.digest/
        delete veto files = yes

        vfs objects = catia fruit streams_xattr recycle
        ea support = yes
        fruit:aapl = yes
        fruit:encoding = native
        fruit:locking = none
        fruit:metadata = stream
        fruit:resource = file

        recycle:repository = @RecycleBin
        recycle:directory_mode = 2775
        recycle:keeptree = yes
        recycle:versions = yes
        recycle:touch = yes
        recycle:exclude = *.tmp,*.temp,*.o,*.obj,~$*,*.~??,~*.*,*.TMP,*.TEMP,lock.*,.~lock.*,LOCK.*,*.lock,*.~lock,*.LNK,*.lnk,*.ldb,._*
        recycle:minsize = 1
Comment 1 LP 2019-12-11 12:14:44 UTC
Could this issue be related to bug #14015?

https://bugzilla.samba.org/show_bug.cgi?id=14015

I don't know in which version the patch for #14015 was implemented but I've tested on 4.10.10 on Fedora 30 and there is still problem with vfs_recycle.