SMB2_NETNAME_NEGOTIATE_CONTEXT_ID containing the target server name, was added as a way to indicate the target server to load balancers. The server is supposed to ignore that, but we may want to use it in order to support %L again, see man smb.conf: %L the NetBIOS name of the server. This allows you to change your config based on what the client calls you. Your server can have a “dual personality”. As the code is trivial an harmless we should backport it in order to make this available sooner.
Created attachment 15449 [details] Patches for v4-9-test
Created attachment 15450 [details] Patches for v4-10-test
Created attachment 15451 [details] Patches for v4-11-test
Reassigning to Karolin for inclusion in 4.9, 4.10 and 4.11.
(In reply to Ralph Böhme from comment #4) Pushed to autobuild-v4-{11,10,9}-test.
Pushed to v4-11-test, seems to break the build on v4-{10,9}-test: [1663/4408] Compiling libcli/smb/smbXcli_base.c ../libcli/smb/smbXcli_base.c: In function ‘smbXcli_negprot_smb2_subreq’: ../libcli/smb/smbXcli_base.c:4805:6: error: incompatible type for argument 4 of ‘smb2_negotiate_context_add’ netname_utf16, netname_utf16_len); ^ In file included from ../libcli/smb/smbXcli_base.c:35:0: ../libcli/smb/smb2_negotiate_context.h:45:10: note: expected ‘DATA_BLOB’ but argument is of type ‘uint8_t *’ NTSTATUS smb2_negotiate_context_add(TALLOC_CTX *mem_ctx, struct smb2_negotiate_contexts *c, ^ ../libcli/smb/smbXcli_base.c:4805:6: error: too many arguments to function ‘smb2_negotiate_context_add’ netname_utf16, netname_utf16_len); ^ In file included from ../libcli/smb/smbXcli_base.c:35:0: ../libcli/smb/smb2_negotiate_context.h:45:10: note: declared here NTSTATUS smb2_negotiate_context_add(TALLOC_CTX *mem_ctx, struct smb2_negotiate_contexts *c, ^ Waf: Leaving directory `/memdisk/kseeger/a49/b1999381/samba/bin' Build failed: -> task failed (err #1): {task: cc smbXcli_base.c -> smbXcli_base_4.o} make: *** [all] Error 1
Created attachment 15466 [details] Patches for v4-10-test The 4.10 and 4.9 patches need to be a bit different in order to compile.
Created attachment 15467 [details] Patches for v4-9-test The 4.10 and 4.9 patches need to be a bit different in order to compile.
Karolin, please push the new 4.9 and 4.10 backports.
(In reply to Ralph Böhme from comment #9) done, thanks!
(In reply to Karolin Seeger from comment #10) Pushed to all branches. Closing out bug report. Thanks!
Oops, just seeing that I was marked as reviewer on this via a reminder email received today. Completely missed it, I'm very sorry :( I don't see an option to mark as reviewed or remove myself from this bug reviewer list. Maybe I'm missing something, or maybe the owner can do it, metze? Sorry for the noise.
Hi Aurelien, Am 11.12.20 um 12:50 schrieb samba-bugs@samba.org: > https://bugzilla.samba.org/show_bug.cgi?id=14055 > > --- Comment #12 from Aurélien Aptel <aaptel@samba.org> --- > Oops, just seeing that I was marked as reviewer on this via a reminder email > received today. Completely missed it, I'm very sorry :( > > I don't see an option to mark as reviewed or remove myself from this bug > reviewer list. Maybe I'm missing something, or maybe the owner can do it, > metze? I just removed these review requests. It should be ok now. Cheers, Karolin