On older systems like SLES 11 without POSIX robust mutexes, but with glib robust mutexes where all the functions are available but have a "_np" suffix, compilation fails in: ctdb/tests/src/test_mutex_raw.c.239.o: In function `worker': /root/samba-4.10.6/bin/default/../../ctdb/tests/src/test_mutex_raw.c:129: undefined reference to `pthread_mutex_consistent' ctdb/tests/src/test_mutex_raw.c.239.o: In function `main': /root/samba-4.10.6/bin/default/../../ctdb/tests/src/test_mutex_raw.c:285: undefined reference to `pthread_mutex_consistent' /root/samba-4.10.6/bin/default/../../ctdb/tests/src/test_mutex_raw.c:332: undefined reference to `pthread_mutexattr_setrobust' /root/samba-4.10.6/bin/default/../../ctdb/tests/src/test_mutex_raw.c:363: undefined reference to `pthread_mutex_consistent' collect2: ld returned 1 exit status This happens because our pthreads shim include isn't included but the systems pthread.h directly. libreplace system/threads.h provides the required define #if defined(HAVE_PTHREAD_MUTEX_CONSISTENT_NP) && \ !defined(HAVE_PTHREAD_MUTEX_CONSISTENT) #define pthread_mutex_consistent pthread_mutex_consistent_np #endif
Do we want to backport commit f5388f97792ac2d7962950dad91aaf8ad49bceaa to any of the release branches?
(In reply to Martin Schwenke from comment #1) I guess so...
Created attachment 15455 [details] backport for 4.11
Created attachment 15456 [details] backport for 4.10
Created attachment 15457 [details] backport for 4.9
Comment on attachment 15457 [details] backport for 4.9 Please add cherry-pick -x information before pushing...
Comment on attachment 15456 [details] backport for 4.10 Please add cherry-pick -x information before pushing...
Comment on attachment 15455 [details] backport for 4.11 Please add cherry-pick -x information before pushing...
Please add cherry-pick -x information before pushing...
Pushed to autobuild-v4-{11,10,9}-test.
(In reply to Karolin Seeger from comment #10) Pushed to all branches. Closing out bug report. Thanks!