Bug 14027 - samba-tool domain backup offline doesn't work against bind DLZ backend
Summary: samba-tool domain backup offline doesn't work against bind DLZ backend
Status: ASSIGNED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: 4.10.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Douglas Bagnall
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks: 14743
  Show dependency treegraph
 
Reported: 2019-07-04 23:16 UTC by Tim Beale
Modified: 2021-07-14 08:15 UTC (History)
7 users (show)

See Also:


Attachments
patch for 4.13 (19.50 KB, patch)
2021-03-24 23:59 UTC, Joseph Sutton
abartlet: review+
slow: review-
Details
patch for 4.14 (19.50 KB, patch)
2021-03-25 00:01 UTC, Joseph Sutton
abartlet: review+
slow: review-
Details
patch for 4.13 (19.83 KB, patch)
2021-05-31 23:36 UTC, Joseph Sutton
no flags Details
patch for 4.14 (19.83 KB, patch)
2021-05-31 23:37 UTC, Joseph Sutton
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Beale 2019-07-04 23:16:47 UTC
The offline backup doesn't work with the BIND DLZ backend. The problem is there is a hard-link for the samb.ldb.d directory, and the backup doesn't account for this, and tries to lock the same .tdb file twice.

The solution would be to just ignore hard-links in the backup process. The restore command may need to recreate the hard-link, I'm not sure (For online backups, we only support the internale DNS backend, so you'd need to upgrade DNS after restoring. However, I'm not sure exactly what is needed in the offline case).

As seen on mailing-list:
https://lists.samba.org/archive/samba/2019-July/224153.html

offline with samba stopped:
# samba-tool domain backup offline --targetdir=/local/test/
INFO: Current debug levels:
  all: 5
  tdb: 5
  printdrivers: 5
  lanman: 5
  smb: 5
  rpc_parse: 5
  rpc_srv: 5
  rpc_cli: 5
  passdb: 5
  sam: 5
  auth: 5
  winbind: 5
  vfs: 5
  idmap: 5
  quota: 5
  acls: 5
  locking: 5
  msdfs: 5
  dmapi: 5
  registry: 5
  scavenger: 5
  dns: 5
  ldb: 5
  tevent: 5
  auth_audit: 5
  auth_json_audit: 5
  kerberos: 5
  drs_repl: 5
  smb2: 5
  smb2_credits: 5
  dsdb_audit: 5
  dsdb_json_audit: 5
  dsdb_password_audit: 5
  dsdb_password_json_audit: 5
  dsdb_transaction_audit: 5
  dsdb_transaction_json_audit: 5
  dsdb_group_audit: 5
  dsdb_group_json_audit: 5
Processing section "[netlogon]"
Processing section "[sysvol]"
pm_process() returned Yes
schema_fsmo_init: we are master[yes] updates allowed[no]
schema_fsmo_init: we are master[yes] updates allowed[no]
running backup on dirs: /usr/local/samba/private
/usr/local/samba/var/locks /usr/local/samba/etc
Starting transaction on /usr/local/samba/private/secrets
Starting transaction on /usr/local/samba/private/sam.ldb
schema_fsmo_init: we are master[yes] updates allowed[no]
   backing up /usr/local/samba/private/sam.ldb
   backing up locked/related file
/usr/local/samba/private/sam.ldb.d/CN%3DCONFIGURATION,DC%3DDOMAIN,DC%3DCAT.ldb
   backing up locked/related file
/usr/local/samba/private/sam.ldb.d/DC%3DDOMAIN,DC%3DCAT.ldb
   backing up locked/related file
/usr/local/samba/private/sam.ldb.d/DC%3DDOMAINDNSZONES,DC%3DDOMAIN,DC%3DCAT.ldb
   backing up locked/related file
/usr/local/samba/private/sam.ldb.d/DC%3DFORESTDNSZONES,DC%3DDOMAIN,DC%3DCAT.ldb
   copying locked/related file /usr/local/samba/private/sam.ldb.d/metadata.tdb
   backing up locked/related file
/usr/local/samba/private/sam.ldb.d/CN%3DSCHEMA,CN%3DCONFIGURATION,DC%3DDOMAIN,DC%3DCAT.ldb
DSDB Transaction [rollback] at [Thu, 04 Jul 2019 09:43:55.250310 CEST]
duration [355670]
{"dsdbTransaction": {"version": {"major": 1, "minor": 0}, "action":
"rollback", "transactionId": "6794551c-fc12-4bbf-9dfd-9f7d78b0953a",
"duration": 355670}, "timestamp": "2019-07-04T09:43:55.250581+0200",
"type": "dsdbTransaction"}
schema_fsmo_init: we are master[yes] updates allowed[no]
DSDB Change [Modify] at [Thu, 04 Jul 2019 09:43:55.416239 CEST] status
[Success] remote host [Unknown] SID [(NULL SID)] DN [@SAMBA_DSDB]
attributes [add: backupDate [2019-07-04T09-43-55.413999]]
{"timestamp": "2019-07-04T09:43:55.416491+0200", "type": "dsdbChange",
"dsdbChange": {"remoteAddress": null, "version": {"major": 1, "minor":
0}, "operation": "Modify", "statusCode": 0, "sessionId":
"bbfe57a0-da36-4bc8-8863-995ad1ea25c7", "dn": "@SAMBA_DSDB", "status":
"Success", "performedAsSystem": false, "userSid": "S-1-5-18",
"transactionId": "6f67143f-9add-47b8-bfa7-2d6c68a19ea9", "attributes":
{"backupDate": {"actions": [{"action": "add", "values": [{"value":
"2019-07-04T09-43-55.413999"}]}]}}}}
DSDB Change [Modify] at [Thu, 04 Jul 2019 09:43:55.431208 CEST] status
[Success] remote host [Unknown] SID [(NULL SID)] DN [@SAMBA_DSDB]
attributes [add: sidForRestore
[S-1-5-21-2329230797-1186182137-2997319902-1207]]
{"timestamp": "2019-07-04T09:43:55.431477+0200", "type": "dsdbChange",
"dsdbChange": {"remoteAddress": null, "version": {"major": 1, "minor":
0}, "operation": "Modify", "statusCode": 0, "sessionId":
"bbfe57a0-da36-4bc8-8863-995ad1ea25c7", "dn": "@SAMBA_DSDB", "status":
"Success", "performedAsSystem": false, "userSid": "S-1-5-18",
"transactionId": "58e89a76-1f9d-433a-b172-04f44c9f9bfd", "attributes":
{"sidForRestore": {"actions": [{"action": "add", "values": [{"value":
"S-1-5-21-2329230797-1186182137-2997319902-1207"}]}]}}}}
DSDB Change [Modify] at [Thu, 04 Jul 2019 09:43:55.434911 CEST] status
[Success] remote host [Unknown] SID [(NULL SID)] DN [@SAMBA_DSDB]
attributes [add: backupType [offline]]
{"timestamp": "2019-07-04T09:43:55.435085+0200", "type": "dsdbChange",
"dsdbChange": {"remoteAddress": null, "version": {"major": 1, "minor":
0}, "operation": "Modify", "statusCode": 0, "sessionId":
"bbfe57a0-da36-4bc8-8863-995ad1ea25c7", "dn": "@SAMBA_DSDB", "status":
"Success", "performedAsSystem": false, "userSid": "S-1-5-18",
"transactionId": "87f71a95-faf7-493a-8057-d38278747099", "attributes":
{"backupType": {"actions": [{"action": "add", "values": [{"value":
"offline"}]}]}}}}
running tdbbackup on lone tdb file /usr/local/samba/private/schannel_store.tdb
Starting transaction on solo db: /usr/local/samba/private/hklm.ldb
   running tdbbackup on the same file
running tdbbackup on lone tdb file
/usr/local/samba/private/netlogon_creds_cli.tdb
tdb_mutex_open_ok[/usr/local/samba/private/netlogon_creds_cli.tdb]:
Can use mutexes only with MUTEX_LOCKING or NOLOCK
Failed to open /usr/local/samba/private/netlogon_creds_cli.tdb
Starting transaction on solo db: /usr/local/samba/private/share.ldb
   running tdbbackup on the same file
Starting transaction on solo db: /usr/local/samba/private/privilege.ldb
   running tdbbackup on the same file
Starting transaction on solo db: /usr/local/samba/private/idmap.ldb
   running tdbbackup on the same file
Starting transaction on solo db: /usr/local/samba/private/dns/sam.ldb
tdb(/usr/local/samba/private/dns/sam.ldb.d/metadata.tdb): tdb_open_ex:
/usr/local/samba/private/dns/sam.ldb.d/metadata.tdb (2049,673298) is
already open in this process
partition_metadata: Migrating partition metadata: open of metadata.tdb
gave: partition_metadata: Unable to open
/usr/local/samba/private/dns/sam.ldb.d/metadata.tdb: Device or
resource busy
tdb(/usr/local/samba/private/dns/sam.ldb.d/metadata.tdb): tdb_open_ex:
/usr/local/samba/private/dns/sam.ldb.d/metadata.tdb (2049,673298) is
already open in this process
module partition initialization failed : Operations error
module show_deleted initialization failed : Operations error
module dns_notify initialization failed : Operations error
module extended_dn_out_ldb initialization failed : Operations error
module linked_attributes initialization failed : Operations error
module unique_object_sids initialization failed : Operations error
module operational initialization failed : Operations error
module encrypted_secrets initialization failed : Operations error
module group_audit_log initialization failed : Operations error
module repl_meta_data initialization failed : Operations error
module subtree_delete initialization failed : Operations error
module aclread initialization failed : Operations error
module acl initialization failed : Operations error
module descriptor initialization failed : Operations error
module objectclass initialization failed : Operations error
module audit_log initialization failed : Operations error
module asq initialization failed : Operations error
module server_sort initialization failed : Operations error
module vlv initialization failed : Operations error
module dsdb_paged_results initialization failed : Operations error
module dirsync initialization failed : Operations error
module schema_load initialization failed : Operations error
module dsdb_notification initialization failed : Operations error
module rootdse initialization failed : Operations error
module samba_dsdb initialization failed : Operations error
Unable to load modules for /usr/local/samba/private/dns/sam.ldb:
partition_metadata: Migrating partition metadata: create of
metadata.tdb gave: partition_metadata: Unable to create
/usr/local/samba/private/dns/sam.ldb.d/metadata.tdb: Device or
resource busy

ERROR(ldb): uncaught exception - partition_metadata: Migrating
partition metadata: create of metadata.tdb gave: partition_metadata:
Unable to create /usr/local/samba/private/dns/sam.ldb.d/metadata.tdb:
Device or resource busy

  File "/usr/local/samba/lib/python3.4/site-packages/samba/netcmd/__init__.py",
line 185, in _run
    return self.run(*args, **kwargs)
  File "/usr/local/samba/lib/python3.4/site-packages/samba/netcmd/domain_backup.py",
line 1072, in run
    ldb_obj = Ldb(path, lp=lp)
  File "/usr/local/samba/lib/python3.4/site-packages/samba/__init__.py",
line 115, in __init__
    self.connect(url, flags, options)
Comment 1 trenta 2019-08-06 09:36:32 UTC
Hi,

Will be solved on next minor release? It is important to ensure
concistent backup for production environment with samba

Any scheduled date for this bug with offline backup mode?

Thanks
Comment 2 trenta 2019-08-10 14:41:46 UTC
any news?
Comment 3 Tim Beale 2019-08-12 00:18:39 UTC
There's been no progress on this so far, and no scheduled fix date.

I think fixing the backup should be fairly trivial, but I think the work to ensure the hardlinks are restored correctly is slightly more fiddly. And then it probably needs an extra test case written for this.

In the meantime, I'd suggest using the online backup option as a work-around, if possible.
Comment 4 trenta 2019-08-12 07:06:59 UTC
Hi,

I think that onlien backup required enter pwd and cannot be scheduled
with crontab, and offline backups allow this...
Comment 5 Amit Kumar 2019-09-02 07:06:37 UTC
(In reply to trenta from comment #4)
[root@sambadom ~]# killall samba

[root@sambadom ~]# ps -aux|grep samba
root      7699  0.0  0.0 215744   828 pts/1    S+   02:04   0:00 grep --color=auto samba

[root@sambadom ~]# samba-tool domain backup offline --targetdir=/root
running backup on dirs: /var/lib/samba/private /var/lib/samba /etc/samba
Starting transaction on /var/lib/samba/private/secrets
Starting transaction on /var/lib/samba/private/sam.ldb
   backing up /var/lib/samba/private/sam.ldb
   backing up locked/related file /var/lib/samba/private/sam.ldb.d/CN=SCHEMA,CN=CONFIGURATION,DC=SAMDOM,DC=AMITEXAMPLE,DC=COM.ldb
   backing up locked/related file /var/lib/samba/private/sam.ldb.d/DC=FORESTDNSZONES,DC=SAMDOM,DC=AMITEXAMPLE,DC=COM.ldb
   backing up locked/related file /var/lib/samba/private/sam.ldb.d/DC=SAMDOM,DC=AMITEXAMPLE,DC=COM.ldb
   backing up locked/related file /var/lib/samba/private/sam.ldb.d/DC=DOMAINDNSZONES,DC=SAMDOM,DC=AMITEXAMPLE,DC=COM.ldb
   copying locked/related file /var/lib/samba/private/sam.ldb.d/metadata.tdb
   backing up locked/related file /var/lib/samba/private/sam.ldb.d/CN=CONFIGURATION,DC=SAMDOM,DC=AMITEXAMPLE,DC=COM.ldb
Starting transaction on solo db: /var/lib/samba/private/idmap.ldb
   running tdbbackup on the same file
Starting transaction on solo db: /var/lib/samba/private/privilege.ldb
   running tdbbackup on the same file
Starting transaction on solo db: /var/lib/samba/private/hklm.ldb
   running tdbbackup on the same file
running tdbbackup on lone tdb file /var/lib/samba/private/schannel_store.tdb
Starting transaction on solo db: /var/lib/samba/private/share.ldb
   running tdbbackup on the same file
running tdbbackup on lone tdb file /var/lib/samba/private/netlogon_creds_cli.tdb
tdb_mutex_open_ok[/var/lib/samba/private/netlogon_creds_cli.tdb]: Can use mutexes only with MUTEX_LOCKING or NOLOCK
Failed to open /var/lib/samba/private/netlogon_creds_cli.tdb
running tdbbackup on lone tdb file /var/lib/samba/account_policy.tdb
running tdbbackup on lone tdb file /var/lib/samba/netsamlogon_cache.tdb
running tdbbackup on lone tdb file /var/lib/samba/share_info.tdb
running tdbbackup on lone tdb file /var/lib/samba/registry.tdb
running tdbbackup on lone tdb file /var/lib/samba/winbindd_cache.tdb
running tdbbackup on lone tdb file /var/lib/samba/smbprofile.tdb
tdb_mutex_open_ok[/var/lib/samba/smbprofile.tdb]: Can use mutexes only with MUTEX_LOCKING or NOLOCK
Failed to open /var/lib/samba/smbprofile.tdb
running tdbbackup on lone tdb file /var/lib/samba/lock/smbd_cleanupd.tdb
tdb_mutex_open_ok[/var/lib/samba/lock/smbd_cleanupd.tdb]: Can use mutexes only with MUTEX_LOCKING or NOLOCK
Failed to open /var/lib/samba/lock/smbd_cleanupd.tdb
running tdbbackup on lone tdb file /var/lib/samba/lock/smbXsrv_version_global.tdb
tdb_mutex_open_ok[/var/lib/samba/lock/smbXsrv_version_global.tdb]: Can use mutexes only with MUTEX_LOCKING or NOLOCK
Failed to open /var/lib/samba/lock/smbXsrv_version_global.tdb
running tdbbackup on lone tdb file /var/lib/samba/lock/smbXsrv_session_global.tdb
tdb_mutex_open_ok[/var/lib/samba/lock/smbXsrv_session_global.tdb]: Can use mutexes only with MUTEX_LOCKING or NOLOCK
Failed to open /var/lib/samba/lock/smbXsrv_session_global.tdb
running tdbbackup on lone tdb file /var/lib/samba/lock/smbXsrv_tcon_global.tdb
tdb_mutex_open_ok[/var/lib/samba/lock/smbXsrv_tcon_global.tdb]: Can use mutexes only with MUTEX_LOCKING or NOLOCK
Failed to open /var/lib/samba/lock/smbXsrv_tcon_global.tdb
running tdbbackup on lone tdb file /var/lib/samba/lock/locking.tdb
tdb_mutex_open_ok[/var/lib/samba/lock/locking.tdb]: Can use mutexes only with MUTEX_LOCKING or NOLOCK
Failed to open /var/lib/samba/lock/locking.tdb
running tdbbackup on lone tdb file /var/lib/samba/lock/gencache.tdb
tdb_mutex_open_ok[/var/lib/samba/lock/gencache.tdb]: Can use mutexes only with MUTEX_LOCKING or NOLOCK
Failed to open /var/lib/samba/lock/gencache.tdb
running tdbbackup on lone tdb file /var/lib/samba/lock/smbXsrv_client_global.tdb
tdb_mutex_open_ok[/var/lib/samba/lock/smbXsrv_client_global.tdb]: Can use mutexes only with MUTEX_LOCKING or NOLOCK
Failed to open /var/lib/samba/lock/smbXsrv_client_global.tdb
running tdbbackup on lone tdb file /var/lib/samba/lock/leases.tdb
tdb_mutex_open_ok[/var/lib/samba/lock/leases.tdb]: Can use mutexes only with MUTEX_LOCKING or NOLOCK
Failed to open /var/lib/samba/lock/leases.tdb
running tdbbackup on lone tdb file /var/lib/samba/lock/smbXsrv_open_global.tdb
tdb_mutex_open_ok[/var/lib/samba/lock/smbXsrv_open_global.tdb]: Can use mutexes only with MUTEX_LOCKING or NOLOCK
Failed to open /var/lib/samba/lock/smbXsrv_open_global.tdb
running tdbbackup on lone tdb file /var/lib/samba/lock/names.tdb
running tdbbackup on lone tdb file /var/lib/samba/lock/printer_list.tdb
tdb_mutex_open_ok[/var/lib/samba/lock/printer_list.tdb]: Can use mutexes only with MUTEX_LOCKING or NOLOCK
Failed to open /var/lib/samba/lock/printer_list.tdb
running tdbbackup on lone tdb file /var/lib/samba/lock/brlock.tdb
tdb_mutex_open_ok[/var/lib/samba/lock/brlock.tdb]: Can use mutexes only with MUTEX_LOCKING or NOLOCK
Failed to open /var/lib/samba/lock/brlock.tdb
running tdbbackup on lone tdb file /var/lib/samba/private/netlogon_creds_cli.tdb
tdb_mutex_open_ok[/var/lib/samba/private/netlogon_creds_cli.tdb]: Can use mutexes only with MUTEX_LOCKING or NOLOCK
Failed to open /var/lib/samba/private/netlogon_creds_cli.tdb
running offline ntacl backup of sysvol
building backup tar
   adding misc file private/spn_update_list
   adding misc file private/ldapi
   adding backup private/secrets.tdb.bak-offline to tar and deleting file
   adding backup private/secrets.ldb.bak-offline to tar and deleting file
   adding misc file private/secrets.keytab
   adding misc file private/dns_update_cache
   adding backup private/idmap.ldb.bak-offline to tar and deleting file
   adding misc file private/dns_update_list
   adding backup private/privilege.ldb.bak-offline to tar and deleting file
   adding misc file private/kdc.conf
   adding backup private/hklm.ldb.bak-offline to tar and deleting file
   adding backup private/schannel_store.tdb.bak-offline to tar and deleting file
   adding backup private/sam.ldb.bak-offline to tar and deleting file
   adding misc file private/krb5.conf
   adding backup private/share.ldb.bak-offline to tar and deleting file
   skipping private/netlogon_creds_cli.tdb
   adding misc file private/encrypted_secrets.key
   adding misc file private/tls/ca.pem
   adding misc file private/tls/key.pem
   adding misc file private/tls/cert.pem
   adding misc file private/ldap_priv/ldapi
   adding backup private/sam.ldb.d/CN=SCHEMA,CN=CONFIGURATION,DC=SAMDOM,DC=AMITEXAMPLE,DC=COM.ldb.bak-offline to tar and deleting file
   adding backup private/sam.ldb.d/DC=FORESTDNSZONES,DC=SAMDOM,DC=AMITEXAMPLE,DC=COM.ldb.bak-offline to tar and deleting file
   adding backup private/sam.ldb.d/DC=SAMDOM,DC=AMITEXAMPLE,DC=COM.ldb.bak-offline to tar and deleting file
   adding backup private/sam.ldb.d/DC=DOMAINDNSZONES,DC=SAMDOM,DC=AMITEXAMPLE,DC=COM.ldb.bak-offline to tar and deleting file
   adding backup private/sam.ldb.d/metadata.tdb.bak-offline to tar and deleting file
   adding backup private/sam.ldb.d/CN=CONFIGURATION,DC=SAMDOM,DC=AMITEXAMPLE,DC=COM.ldb.bak-offline to tar and deleting file
   adding backup statedir/account_policy.tdb.bak-offline to tar and deleting file
   adding backup statedir/netsamlogon_cache.tdb.bak-offline to tar and deleting file
   adding backup statedir/share_info.tdb.bak-offline to tar and deleting file
   adding backup statedir/registry.tdb.bak-offline to tar and deleting file
   adding backup statedir/winbindd_cache.tdb.bak-offline to tar and deleting file
   skipping statedir/smbprofile.tdb
   skipping statedir/lock/smbd_cleanupd.tdb
   skipping statedir/lock/smbXsrv_version_global.tdb
   skipping statedir/lock/smbXsrv_session_global.tdb
   skipping statedir/lock/smbXsrv_tcon_global.tdb
   skipping statedir/lock/locking.tdb
   skipping statedir/lock/gencache.tdb
   skipping statedir/lock/smbXsrv_client_global.tdb
   skipping statedir/lock/leases.tdb
   skipping statedir/lock/smbXsrv_open_global.tdb
   adding backup statedir/lock/names.tdb.bak-offline to tar and deleting file
   skipping statedir/lock/printer_list.tdb
   skipping statedir/lock/brlock.tdb
   adding misc file statedir/lock/msg.lock/2057
   adding misc file statedir/lock/msg.lock/2058
   adding misc file statedir/lock/msg.lock/1968
   adding misc file statedir/lock/msg.lock/1988
   adding misc file statedir/lock/msg.lock/1997
   adding misc file statedir/lock/msg.lock/1964
   adding misc file statedir/lock/msg.lock/1976
   adding misc file statedir/lock/msg.lock/1960
   adding misc file statedir/lock/msg.lock/1967
   adding misc file statedir/lock/msg.lock/1970
   adding misc file statedir/lock/msg.lock/1987
   adding misc file statedir/lock/msg.lock/1969
   adding misc file statedir/lock/msg.lock/1978
   adding misc file statedir/lock/msg.lock/1961
   adding misc file statedir/bind-dns/named.conf.update
   adding misc file statedir/ntp_signd/socket
   adding misc file private/spn_update_list
   adding misc file private/ldapi
   skipping private/secrets.tdb
   skipping private/secrets.ldb
   adding misc file private/secrets.keytab
   adding misc file private/dns_update_cache
   skipping private/idmap.ldb
   adding misc file private/dns_update_list
   skipping private/privilege.ldb
   adding misc file private/kdc.conf
   skipping private/hklm.ldb
   skipping private/schannel_store.tdb
   skipping private/sam.ldb
   adding misc file private/krb5.conf
   skipping private/share.ldb
   skipping private/netlogon_creds_cli.tdb
   adding misc file private/encrypted_secrets.key
   adding misc file private/tls/ca.pem
   adding misc file private/tls/key.pem
   adding misc file private/tls/cert.pem
   adding misc file private/ldap_priv/ldapi
   skipping private/sam.ldb.d/CN=SCHEMA,CN=CONFIGURATION,DC=SAMDOM,DC=AMITEXAMPLE,DC=COM.ldb
   skipping private/sam.ldb.d/DC=FORESTDNSZONES,DC=SAMDOM,DC=AMITEXAMPLE,DC=COM.ldb
   skipping private/sam.ldb.d/DC=SAMDOM,DC=AMITEXAMPLE,DC=COM.ldb
   skipping private/sam.ldb.d/DC=DOMAINDNSZONES,DC=SAMDOM,DC=AMITEXAMPLE,DC=COM.ldb
   skipping private/sam.ldb.d/metadata.tdb
   skipping private/sam.ldb.d/CN=CONFIGURATION,DC=SAMDOM,DC=AMITEXAMPLE,DC=COM.ldb
   adding misc file statedir/winbindd_privileged/pipe
   adding misc file etc/lmhosts
   adding misc file etc/smb.conf-bak
   adding misc file etc/smb.conf
   adding misc file etc/smb.conf-SAMBADOM
   adding misc file etc/smb.conf.example
Backup succeeded.
[root@sambadom ~]# ls -ltr
-rw-r--r--. 1 root root 1434398 Sep  2 02:04 samba-backup-2019-09-02T02-04-27.209038.tar.bz2

-> samba-dc-4.10.6-0.fc30.x86_64
Comment 6 Michal Bruncko 2020-10-30 21:28:19 UTC
I can confirm this issue is still in place in samba-4.12.6
Comment 7 Stefan Kania 2021-03-03 18:33:53 UTC
The problem still exist in 4.14rc3
Comment 8 Samba QA Contact 2021-03-24 00:47:03 UTC
This bug was referenced in samba master:

542678908ac9869bca53b83db7c61d53d898c69c
f52e6e5345bd7cf35abe49eb67e9e4ea969493fd
09995f780d1e75618ffc50b870b32e2375b63747
05b17c98598168b6d74a3f2dd0d9973e3bf407c1
Comment 9 Joseph Sutton 2021-03-24 23:59:08 UTC
Created attachment 16566 [details]
patch for 4.13
Comment 10 Joseph Sutton 2021-03-25 00:01:56 UTC
Created attachment 16567 [details]
patch for 4.14
Comment 11 Elias 2021-04-24 16:15:32 UTC
Hello,

This patch was not applied in version 4.14.3, right?

https://www.samba.org/samba/history/samba-4.14.3.html
Comment 12 Karolin Seeger 2021-04-26 06:43:19 UTC
(In reply to Elias from comment #11)
Hello,

right. It needs a second review from a team member and needs to be assigned to me after that. Re-assigning to Douglas for review.
Comment 13 Ralph Böhme 2021-04-26 07:31:58 UTC
Comment on attachment 16566 [details]
patch for 4.13

Patches are lacking cherry-pick info.
Comment 14 Ralph Böhme 2021-04-26 07:32:04 UTC
Comment on attachment 16567 [details]
patch for 4.14

Patches are lacking cherry-pick info.
Comment 15 Douglas Bagnall 2021-04-27 02:07:53 UTC
(In reply to Ralph Böhme from comment #14)

Joseph, what Ralph refers to is the backports should be done using `git cherry-pick -x` which adds a "(cherry-picked from commit ...)" line to the commit message. It helps with cross referencing.

https://wiki.samba.org/index.php/Samba_Release_Planning#Patch_Process
Comment 16 Elias 2021-04-27 12:35:47 UTC
(In reply to Karolin Seeger from comment #12)
Hello,

Is there any way I can apply this patch to my installation? I installed it via .deb packages.
Comment 17 Louis 2021-04-28 07:43:30 UTC
(In reply to Elias from comment #16)
Hai Elias, Give me some time, i'll add this one in my package. 
Greetz, Louis
Comment 18 Elias 2021-04-28 13:36:03 UTC
(In reply to Louis from comment #17)
Hello Louis,

Of course!!! :D
Comment 19 Louis 2021-04-28 13:46:45 UTC
(In reply to Elias from comment #18)

The 4.14.3 in the repo now include the patches
you can test them.
Comment 20 Elias 2021-04-28 19:34:34 UTC
(In reply to Louis from comment #19)
hello Louis,
Now, working!!!
Thanks!!!!
Comment 21 Joseph Sutton 2021-05-31 23:36:51 UTC
Created attachment 16634 [details]
patch for 4.13
Comment 22 Joseph Sutton 2021-05-31 23:37:44 UTC
Created attachment 16635 [details]
patch for 4.14
Comment 23 Samba QA Contact 2021-07-12 13:54:01 UTC
This bug was referenced in samba v4-14-test:

b095932a303c881b459ba73e222b6ed199f673dc
5b361227e7cd259b5585b4e9ad0df7ccd1021580
7a7bfba1d981edca2dc54db9c43c7f6b9310bc39
c1ac591c1976278aac7c26f91d87acdf37bdfb77
Comment 24 Samba QA Contact 2021-07-13 10:33:48 UTC
This bug was referenced in samba v4-14-stable (Release samba-4.14.6):

b095932a303c881b459ba73e222b6ed199f673dc
5b361227e7cd259b5585b4e9ad0df7ccd1021580
7a7bfba1d981edca2dc54db9c43c7f6b9310bc39
c1ac591c1976278aac7c26f91d87acdf37bdfb77
Comment 25 Samba QA Contact 2021-07-13 13:19:05 UTC
This bug was referenced in samba v4-13-test:

6569d0b99672e8752eb13704056094a729d929c5
4a68b1cb2dc9b32f49423b96c1fd935f5886d057
54c353e9ad65a8a764963bddd6396dab4779bfe3
303a0ecdd9d6c3072824380b4faa88cb0821f117
Comment 26 Samba QA Contact 2021-07-14 08:15:07 UTC
This bug was referenced in samba v4-13-stable (Release samba-4.13.10):

6569d0b99672e8752eb13704056094a729d929c5
4a68b1cb2dc9b32f49423b96c1fd935f5886d057
54c353e9ad65a8a764963bddd6396dab4779bfe3
303a0ecdd9d6c3072824380b4faa88cb0821f117