Bug 13975 - Fixup tcopy_passwd() to also copy the pw_comment field
Summary: Fixup tcopy_passwd() to also copy the pw_comment field
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All All
: P5 minor (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-29 13:54 UTC by Stefan Behrens
Modified: 2019-05-30 22:50 UTC (History)
0 users

See Also:

Attachments
Also copy pw_comment in tcopy_passwd() (1.76 KB, text/plain)
2019-05-29 13:54 UTC, Stefan Behrens 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Behrens 2019-05-29 13:54:55 UTC 
Created attachment 15203 [details]
Also copy pw_comment in tcopy_passwd()

All fields of the passwd structure are copied in tcopy_passwd() except for pw_comment, and I needed pw_comment to be copied and here is the patch for the change.
Comment 1 Jeremy Allison 2019-05-30 22:50:07 UTC 
That looks clean to me. Can you either submit it to samba-technical or on the gitlab-CI and create a merge request once it passes ?

Thanks,

Jeremy.