Bug 13974 - Old max block size isn't allowed in options
Summary: Old max block size isn't allowed in options
Status: RESOLVED FIXED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.1.3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-29 05:26 UTC by Matthew Stapleton
Modified: 2020-04-05 17:08 UTC (History)
0 users

See Also:

Attachments
rsync_allow_old_max_block_size_in_options.patch (642 bytes, patch)
2019-05-29 05:26 UTC, Matthew Stapleton 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Stapleton 2019-05-29 05:26:06 UTC 
Created attachment 15199 [details]
rsync_allow_old_max_block_size_in_options.patch

Old large block sizes with protocol < 30 aren't allowed due to a check in options.c added in commit: d74512eb054666198203cdaaaca29a18ba958725.  I have attached a patch which fixes this problem.
Comment 1 Wayne Davison 2020-04-05 17:08:31 UTC 
Thanks for the patch. I've put something similar into options.c to fix this.