This is a regression introduced with d6518d74dda517c84f7a4a2fe3ad37857fb9d7b0 in Samba 4.8. Patch will follow.
Created attachment 15137 [details] patch for 4.10
Created attachment 15138 [details] patch for 4.9
Created attachment 15139 [details] patch for 4.8
Comment on attachment 15138 [details] patch for 4.9 LGTM
Comment on attachment 15137 [details] patch for 4.10 LGTM
Comment on attachment 15139 [details] patch for 4.8 LGTM
Karolin, please add these patches accordingly. Thanks!
(In reply to Guenther Deschner from comment #7) Pushed to autobuild-v4-{9,10}-test.
This needs more work. Reassigning.
Patchset for master: https://gitlab.com/samba-team/samba/merge_requests/464
Created attachment 15184 [details] additional patches for 4.10
Created attachment 15185 [details] additional patches for 4.9
Created attachment 15186 [details] additional patches for 4.8
Comment on attachment 15184 [details] additional patches for 4.10 LGTM
Comment on attachment 15185 [details] additional patches for 4.9 LGTM
Comment on attachment 15186 [details] additional patches for 4.8 LGTM
Karolin, please add to 4.8, 4.9 and 4.10 (unless Andreas has some more things to look after here). Thanks!
(In reply to Guenther Deschner from comment #17) Pushed to autobuild-v4-{10,9}-test. 4.8 is in the security fixes only mode...
(In reply to Karolin Seeger from comment #18) The additional patch introduces a compile issue: [2392/3377] Compiling source3/client/smbspool.c ../source3/client/smbspool.c: In function ‘kerberos_ccache_is_valid’: ../source3/client/smbspool.c:653:4: error: implicit declaration of function ‘krb5_free_unparsed_name’ [-Werror=implicit-function-declaration] krb5_free_unparsed_name(ctx, princ_name); ^ cc1: all warnings being treated as errors Waf: Leaving directory `/memdisk/kseeger/a49/b545967/samba-nopython/bin' Build failed: -> task failed (err #1): {task: cc smbspool.c -> smbspool_157.o} Removed for now. Re-assigning to Günther.
We need to link to krb5_wrap as heimdal doesn't provide the function and we implemented it in krb5_wrap.
Created attachment 15255 [details] additional patches for 4.9 (v2)
Created attachment 15256 [details] another additional patches for 4.10
Comment on attachment 15255 [details] additional patches for 4.9 (v2) LGTM
Comment on attachment 15256 [details] another additional patches for 4.10 LGTM
Karolin, please add the remaining patches as well. Thanks!
(In reply to Guenther Deschner from comment #25) Pushed new additional patch to autobuild-v4-9-test. Additional patch v2 for 4.10 does not apply. Re-assigning to Andreas.
additional patches for 4.9 (v2) breaks build
This feature may have introduced a regression in samba 4.9: See https://bugs.debian.org/931717
Created attachment 15298 [details] patch for 4.9 I've regenerated the patch for the v4-9-test branch.
A user has confirmed that this bug was resolved in Samba 4.10.6 (https://bugzilla.rosalinux.ru/show_bug.cgi?id=9878#c22). Thanks to everyone involved.
Comment on attachment 15298 [details] patch for 4.9 LGTM and Rosa Linux user reported it fixed the problem.
Karolin, could you please try to apply the 4.9 patch again? Thanks!
(In reply to Andreas Schneider from comment #32) Pushed to autobuild-v4-9-test.
(In reply to Karolin Seeger from comment #33) Build fails again with the same error: [3179/4406] Compiling source3/client/smbspool.c ../source3/client/smbspool.c: In function ‘kerberos_ccache_is_valid’: ../source3/client/smbspool.c:653:4: error: implicit declaration of function ‘krb5_free_unparsed_name’ [-Werror=implicit-function-declaration] krb5_free_unparsed_name(ctx, princ_name);