Bug 13907 - regfio: Return instead of assert for short blocks
Summary: regfio: Return instead of assert for short blocks
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL: https://gitlab.com/samba-team/samba/m...
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-19 18:59 UTC by hansmi
Modified: 2019-06-27 09:55 UTC (History)
1 user (show)

See Also:

Attachments
regfio: Return instead of assert for short blocks (1.17 KB, patch)
2019-04-19 18:59 UTC, hansmi 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hansmi 2019-04-19 18:59:36 UTC 
Created attachment 15088 [details]
regfio: Return instead of assert for short blocks

Since a few days creating merge requests on [1] as documented on [2] isn't possible anymore. The attached patch fixes a minor annoyance in the regfio code.

[1] https://gitlab.com/samba-team/samba/merge_requests
[2] https://wiki.samba.org/index.php/Samba_CI_on_gitlab#Creating_a_merge_request
Comment 1 Andrew Bartlett 2019-04-23 05:20:31 UTC 
Sorry about that.  Merge requests are back now.
Comment 2 Andrew Bartlett 2019-06-11 13:05:50 UTC 
I've created the merge request.
Comment 3 Andrew Bartlett 2019-06-27 09:55:19 UTC 
Fixed in master as b201dd33e0403d7259b91d4fcd4df2445703a34c for Samba 4.11