Bug 13872 - gluster vfs modules break the build on some platforms
gluster vfs modules break the build on some platforms
Status: ASSIGNED
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules
4.9.5
All All
: P5 regression
: ---
Assigned To: Karolin Seeger
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-03-30 15:59 UTC by Björn Jacke
Modified: 2019-04-17 10:48 UTC (History)
4 users (show)

See Also:


Attachments
patch from master for v4.9 and v4.10 (1.22 KB, patch)
2019-04-16 15:20 UTC, Guenther Deschner
asn: review+
bjacke: review-
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2019-03-30 15:59:58 UTC
with 4.9.5 there came a new vfs module glusterfs_fuse, which breaks the build on some platforms, just experienced this on AIX. The gluster module use the NAME_MAX macro, which may NOT nbe expected to be defined by POSIX, see https://pubs.opengroup.org/onlinepubs/7908799/xsh/limits.h.html, you should use pathconf() to get the value of NAME_MAX using that. I'm also wondering if a the glusterfs modules shouldn't be only built on platforms there glusterfs is actually availble on.
Comment 1 Karolin Seeger 2019-04-02 07:03:10 UTC
ping
Comment 2 Guenther Deschner 2019-04-16 15:20:30 UTC
Created attachment 15074 [details]
patch from master for v4.9 and v4.10
Comment 3 Andreas Schneider 2019-04-16 17:06:14 UTC
Karolin, please add the patches to the relevant branches. Thanks!
Comment 4 Karolin Seeger 2019-04-17 07:17:54 UTC
Pushed to autobuild-v4-{10,9}-test.
Comment 5 Björn Jacke 2019-04-17 10:44:06 UTC
this patch defies NAME_MAX statucally to 255 in replace.h. This is the wrind approach. My initial comment already mentioned the corrwct approach, please undo the static setting to 255
Comment 6 Björn Jacke 2019-04-17 10:48:28 UTC
in addition to that please do not add this module to the default modules to build for all (also glusterfs unsupported) platforms