Bug 13863 - Our SMB2 credit handling should match Windows Server 2016
Summary: Our SMB2 credit handling should match Windows Server 2016
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.10.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-28 14:37 UTC by Stefan Metzmacher
Modified: 2019-04-25 07:04 UTC (History)
2 users (show)

See Also:

Attachments
Patch for v4-10-test (2.85 KB, text/plain)
2019-04-15 14:00 UTC, Stefan Metzmacher 		jra: review+
Details
Patch for v4-9-test (2.83 KB, text/plain)
2019-04-15 14:00 UTC, Stefan Metzmacher 		jra: review+
Details
Patch for v4-8-test (2.83 KB, text/plain)
2019-04-15 14:01 UTC, Stefan Metzmacher 		jra: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2019-03-28 14:37:16 UTC 
It turns out that the credit handling has changed in Windows Server 2016,
it now grants up to 8192 credits on an authenticated connection without
the ramp of just adding 31 more credits per request.

It also turns out that our client libraries/torture tests are missing
credit charge handling and make it impossible to test size limits of various
SMB2 requests.
Comment 1 Stefan Metzmacher 2019-04-15 14:00:26 UTC 
Created attachment 15071 [details]
Patch for v4-10-test
Comment 2 Stefan Metzmacher 2019-04-15 14:00:55 UTC 
Created attachment 15072 [details]
Patch for v4-9-test
Comment 3 Stefan Metzmacher 2019-04-15 14:01:24 UTC 
Created attachment 15073 [details]
Patch for v4-8-test
Comment 4 Jeremy Allison 2019-04-15 18:40:54 UTC 
Re-assigning to Karolin for inclusion in 4.10.next, 4.9.next, (4.8.next?).
Comment 5 Karolin Seeger 2019-04-16 07:39:04 UTC 
(In reply to Jeremy Allison from comment #4)
Pushed to autobuild-v4-{10,9}-test.
Comment 6 Karolin Seeger 2019-04-25 07:04:39 UTC 
(In reply to Karolin Seeger from comment #5)
Pushed to both branches.
Closing out bug report.

Thanks!