Bug 13852 - Empty attributes list across LDAP
Summary: Empty attributes list across LDAP
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Gary Lockyer
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-21 05:10 UTC by Aaron Haslett (dead mail address)
Modified: 2026-03-04 21:17 UTC (History)
3 users (show)

See Also:

Attachments
ildap empty attrs patch (2.10 KB, patch)
2019-03-28 03:13 UTC, Aaron Haslett (dead mail address) 		no flags Details
Patch version 2 (4.54 KB, patch)
2026-01-20 22:06 UTC, Gary Lockyer 		no flags Details
patch for 4.24, 4.23, 4.22 (4.80 KB, patch)
2026-01-21 03:51 UTC, Douglas Bagnall 		gary: review+
Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Haslett (dead mail address) 2019-03-21 05:10:16 UTC 
An LDB request interprets an empty attribute list as a request for no attributes, but LDAP interprets an empty list as a request for all attributes, and ["1.1"] as a request for no attributes, as per RFC4511:4.5.1.8(SearchRequest.attributes).  We need to convert [] to ["1.1"] in the ildap module before the request goes out.
Comment 1 Aaron Haslett (dead mail address) 2019-03-28 03:13:45 UTC 
Created attachment 15014 [details]
ildap empty attrs patch

Fix and knownfail delete
Comment 2 Gary Lockyer 2026-01-20 22:06:16 UTC 
Created attachment 18801 [details]
Patch version 2

Updated patch with extra tests.
Comment 3 Samba QA Contact 2026-01-21 03:30:03 UTC 
This bug was referenced in samba master:

2a5135fe15e9391a2c9a6b7292fa8094e7754966
Comment 4 Douglas Bagnall 2026-01-21 03:51:59 UTC 
Created attachment 18802 [details]
patch for 4.24, 4.23, 4.22