Bug 13838 - CTDB packaging includes system library directory
Summary: CTDB packaging includes system library directory
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: CTDB (show other bugs)
Version: 4.8.9
Hardware: All All
: P5 minor (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
Depends on:
Reported: 2019-03-14 05:07 UTC by Martin Schwenke
Modified: 2019-03-28 08:11 UTC (History)
1 user (show)

See Also:

Patch for 4.9 and 4.10 (1.87 KB, patch)
2019-03-19 03:49 UTC, Martin Schwenke
amitay: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Schwenke 2019-03-14 05:07:01 UTC
The standalone ctdb.spec.in file attempts to package (for example) /usr/lib rather than /usr/lib/ctdb.  This is a typo and causes installation failure on at least CentOS 7... it worked fine on RHEL 6.

Note that we expect that this file is only used by CTDB developers.  It is not used by autobuild and is almost certainly not used by anyone building production CTDB packages.  If it was, then someone else would have found the bug.  ;-)

We would like to include an extra patch that adds a new dependency for the ctdb-test package.  One again, we believe that we are the only users of this package.

Therefore, we suggest that it would be safe to include the fix for this in 4.10.0 but it certainly isn't a blocker so it doesn't need to be included.  Including it sooner rather than later just simplifies our own CI.
Comment 1 Martin Schwenke 2019-03-19 03:49:23 UTC
Created attachment 14938 [details]
Patch for 4.9 and 4.10

Same patch applies to both 4.9 and 4.10.
Comment 2 Amitay Isaacs 2019-03-19 23:20:43 UTC
Hi Karolin,

This is ready for v4-9 and v4-10.

Comment 3 Karolin Seeger 2019-03-21 12:22:42 UTC
(In reply to Amitay Isaacs from comment #2)
Pushed to autobuild-v4-{10,9}-test.
Comment 4 Karolin Seeger 2019-03-28 08:11:05 UTC
(In reply to Karolin Seeger from comment #3)
Pushed to both branches.
Closing out bug report.