On a system where locale is not set to utf8, make will fail with encoding error. The details and fix is in commit 87149445af26b8577566dfe5e311b32e3650c6e6 in master branch already. However, it's not backported to 4.10 yet.
Created attachment 14911 [details] backport patch to fix make error CI is in progress: https://gitlab.com/catalyst-samba/samba/pipelines/50864620 which is branch v4-10-test + cherry-pick, have to also remove swap in .gitlab-ci.yml for ci to start.
Comment on attachment 14911 [details] backport patch to fix make error Can I get a second team reviewer please?
The patchs works for my Debian Stretch builds with 4.10.0rc4 Thanks for the patch notification.
Karolin, Please select for the next available 4.10.x release to allow builds with the new python3 default in packaging chroot environments where (eg) LANG=en_US.utf8 is not set. Thanks!
(In reply to Andrew Bartlett from comment #4) Pushed to autobuild-v4-10-test.
(In reply to Karolin Seeger from comment #5) Patch does not apply on current v4-10-test branch: Applying: s4/scripting/bin: open unicode files with utf8 encoding and write unicode string error: patch failed: source4/scripting/bin/gen_ntstatus.py:20 error: source4/scripting/bin/gen_ntstatus.py: patch does not apply error: patch failed: source4/scripting/bin/gen_werror.py:20 error: source4/scripting/bin/gen_werror.py: patch does not apply Patch failed at 0001 s4/scripting/bin: open unicode files with utf8 encoding and write unicode string
Hi Karolin, I had a double check, the patch has already been applied to v4-10-test branch as 7bd135d25d67c96b92f732bee1d4acad67db241c.
Fixed per comment #7