The Samba-Bugzilla – Bug 13789
ctdb_version.h is not always rebuilt when required
Last modified: 2019-03-21 12:07:38 UTC
Some changes in version file generation mean that ctdb_version.h is not necessarily re-generated when the version is changed (e.g. when changing branches).
Created attachment 14851 [details]
A patch I found again today...
The only problem with this is that versions from bin/ctdb don't work together
with installed binaries, which is bad!
That looks nice and simple. I think it needs this squashed in:
diff --git a/ctdb/include/ctdb_version.h b/ctdb/include/ctdb_version.h
index 6558974f003..cf27179aff8 100644
@@ -1,3 +1,3 @@
-#define CTDB_VERSION_STRING SAMBA_VERSION_DOT_STRING
+#define CTDB_VERSION_STRING SAMBA_VERSION_STRING
I'm just wondering why you say that versions from bin/ctdb don't work together with installed binaries?
Created attachment 14936 [details]
Patch for 4.10
This is ready for v4-10.
(In reply to Amitay Isaacs from comment #4)
Pushed to autobuild-v4-10-test.