Re-assiging to Noel.

I noticed that this is caused by always using .decode('utf8').

git grep decode buildtools/
buildtools/wafsamba/samba_abi.py:    sigs = Utils.cmd_output([abi_gen, libpath]).decode('utf8')
buildtools/wafsamba/samba_conftests.py:        ret = Utils.cmd_output(cmd).decode('utf8')
buildtools/wafsamba/samba_conftests.py:        out = Utils.cmd_output(cmd).decode('utf8').split('\n')
buildtools/wafsamba/samba_cross.py:                ans = (p.returncode, ce_out.decode('utf8'))
buildtools/wafsamba/samba_dist.py:    return Utils.cmd_output(ls_files_cmd, cwd=cwd, env=env).decode('utf8').split('\n')
buildtools/wafsamba/samba_perl.py:            output = output.decode('utf8')
buildtools/wafsamba/samba_version.py:    git = Utils.cmd_output(env.GIT + ' show --pretty=format:"%h%n%ct%n%H%n%cd" --stat HEAD', silent=True, env=environ).decode('utf8')


Looking at python/samba/compat.py I think we need to use something like
get_string(), which avoids decode('utf8') unless we're using python3.

The specific difference is that 'getconf LFS_CFLAGS' returns a non empty
string on e.g. on rhel6-i386.

But the same can happen with any other usage of .decode('utf8')


I noticed this in third_party/waf/waflib/fixpy2.py
code = code.replace(".decode(sys.stdout.encoding or'latin-1',errors='replace')", '')
which seems to remove .decode(sys.stdout.encoding or'latin-1',errors='replace')
with nothing when executing in python2.

This looked familiar

https://lists.samba.org/archive/samba-technical/2019-January/thread.html#132069
should fix this (it needs a second reviewer) Can you verify it works

(In reply to Noel Power from comment #3)

No, that just fix the specific problem not all of them!

We just should not use .decode('utf-8') when using python2.

(In reply to Stefan Metzmacher from comment #4)
To be honest I would have liked not to change more than necessary waf (especially for py2)

git grep isinstance buildtools/ | grep str 
buildtools/wafsamba/samba_deps.py:            if not isinstance(s, str):
buildtools/wafsamba/samba_dist.py:    if not isinstance(appname, str) or not appname:
buildtools/wafsamba/samba_perl.py:        if not isinstance(output, str):
buildtools/wafsamba/samba_utils.py:    if isinstance(str, list):
buildtools/wafsamba/samba_utils.py:    if isinstance(varstr, list):
buildtools/wafsamba/samba_utils.py:    if not isinstance(varstr, str):
buildtools/wafsamba/samba_utils.py:        if not isinstance(interp, str):
buildtools/wafsamba/samba_version.py:            if isinstance(value, string_types):
buildtools/wafsamba/samba_waf18.py:        if isinstance(xx, str):
buildtools/wafsamba/samba_waf18.py:   assert key and isinstance(key, str)
buildtools/wafsamba/samba_waf18.py:    assert key and isinstance(key, str)
buildtools/wafsamba/samba_waf18.py:    kw['shell'] = isinstance(cmd, str)
buildtools/wafsamba/wafsamba.py:        shell=isinstance(rule, str),
buildtools/wafsamba/wafsamba.py:    if not isinstance(file, str):

makes me think maybe you are right :/

Created attachment 14825 [details]
maybe patch for master

lets see how this goes

https://gitlab.com/samba-team/devel/samba/pipelines/46402178

Created attachment 14828 [details]
master patch

maybe
https://gitlab.com/samba-team/devel/samba/pipelines/46409483

will have better success

(In reply to Noel Power from comment #7)

Thanks Noel!

Karolin, please test that patch. If fixes your problem we should push it to master and backport it to 4.10.

(In reply to Stefan Metzmacher from comment #8)
Patch fixes the problem. :-)

Thanks!

Pushed to autobuild-master.

Created attachment 14846 [details]
4.10 backport

Comment on attachment 14846 [details]
4.10 backport

I forgot about this, here is the 4.10 backported fix

(In reply to Noel Power from comment #12)
Pushed to autobuild-v4-10-test.

(In reply to Karolin Seeger from comment #13)
Pushed to v4-10-test.
Closing out bug report.

Thanks!