Bug 13766 - printcap still processed with "load printers" disabled in smb.conf
printcap still processed with "load printers" disabled in smb.conf
Status: ASSIGNED
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Printing
unspecified
All All
: P5 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-01-29 00:53 UTC by David Disseldorp
Modified: 2019-02-08 10:14 UTC (History)
3 users (show)

See Also:


Attachments
proposed patchset, currently undergoing testing (4.26 KB, patch)
2019-01-29 01:03 UTC, David Disseldorp
no flags Details
cherry-pick for 4.9.next and 4.10.next (4.56 KB, patch)
2019-02-06 17:07 UTC, David Disseldorp
asn: review+
gd: review+
Details
backport for 4.8.next (load_printers() takes ev and msg contexts) (4.63 KB, patch)
2019-02-06 23:49 UTC, David Disseldorp
asn: review+
gd: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Disseldorp 2019-01-29 00:53:31 UTC
According to the smb.conf man page, the "load printers" smb.conf global should have the following effect:

  A boolean variable that controls whether all printers in the printcap
  will be loaded for browsing by default.
  See the <smbconfoption name="printers"/> section for more details.

lp_load_printers() is currently only checked in the load_printers() code-path prior to pcap_printer_read_fn(). It should also be considered in the pcap_cache_reload() code path.
Comment 1 David Disseldorp 2019-01-29 01:03:44 UTC
Created attachment 14804 [details]
proposed patchset, currently undergoing testing
Comment 2 David Disseldorp 2019-02-06 17:01:40 UTC
(In reply to David Disseldorp from comment #1)
> Created attachment 14804 [details]
> proposed patchset, currently undergoing testing

This has been merged upstream. 4.9 and 4.8 patches to follow...
Comment 3 David Disseldorp 2019-02-06 17:07:11 UTC
Created attachment 14829 [details]
cherry-pick for 4.9.next and 4.10.next
Comment 4 David Disseldorp 2019-02-06 23:49:31 UTC
Created attachment 14830 [details]
backport for 4.8.next (load_printers() takes ev and msg contexts)
Comment 5 Andreas Schneider 2019-02-07 07:40:23 UTC
Comment on attachment 14829 [details]
cherry-pick for 4.9.next and 4.10.next

Dave, do you want to have this patch in 4.10 too?
Comment 6 David Disseldorp 2019-02-07 10:02:17 UTC
(In reply to Andreas Schneider from comment #5)
> Comment on attachment 14829 [details]
> cherry-pick for 4.9.next
> 
> Dave, do you want to have this patch in 4.10 too?

Yes, I hadn't seen that we'd already branched. Will update the summary.
Comment 7 David Disseldorp 2019-02-07 10:19:45 UTC
@Karo please apply for 4.8, 4.9 and 4.10.
Comment 8 Guenther Deschner 2019-02-07 13:54:51 UTC
Comment on attachment 14829 [details]
cherry-pick for 4.9.next and 4.10.next

LGTM
Comment 9 Guenther Deschner 2019-02-07 13:55:48 UTC
Comment on attachment 14830 [details]
backport for 4.8.next (load_printers() takes ev and msg contexts)

LGTM too
Comment 10 Karolin Seeger 2019-02-08 10:14:43 UTC
(In reply to Guenther Deschner from comment #9)
Pushed to autobuild-v4-{10,9,8}-test.