The Samba-Bugzilla – Bug 13727
Netbios traffic on port 139 is still sent with nmbd disabled and 'disable netbios' set
Last modified: 2019-01-17 19:24:37 UTC
Samba configured for use 445 port instead of NetBIOS API.
- disabled nmbd,
- add 'disable netbios' set to 'yes' in smb.conf
- add 'smb ports = 445' in smb.conf
but its still sending netbios-ssn to domain controller on port 139.
disable_netbios option is not evaluated in some calls to cli_connect_nb()
Created attachment 14759 [details]
Created attachment 14760 [details]
Comment on attachment 14760 [details]
Ups wrong patch.
Woops, uploaded the wrong patches. Disregard the patches before this comment. I will upload the correct ones soon.
attachment #14760 [details] is obsolete or not ?
Created attachment 14763 [details]
Created attachment 14764 [details]
Apologies for the confusion, the correct patches are added now.
Karolin, please add the patch to the next 4.9 release. Thanks!
Comment on attachment 14764 [details]
smbsock_connect_send() should also skip this!
state->req_139 = tevent_wakeup_send(...
I think we should just add something like:
Please also use git cherry-pick -x when creating backports the next time, thanks!
Created attachment 14777 [details]
patch for 4.9
Comment on attachment 14777 [details]
patch for 4.9
Can you put the line:
in the commit comment section of:
[PATCH 1/5] s3:libsmb: Check disable_netbios in socket connect
please ? That way all associated patches are flagged with the correct bugid.
Created attachment 14785 [details]
patch v2 for 4.9
I've added the bug marker.
Created attachment 14787 [details]
patch for 4.10
Re-assigning to Karolin for inclusion in 4.9.next, 4.10.rcNext.