file_lines_parse() only recognises lines that end in a newline character. If a configuration file is edited using an editor that does not insist on the trailing newline (e.g. Emacs) then the last line can be ignored. An example of this is the CTDB public addresses file. I noticed this after seeing the following update to the wiki: https://wiki.samba.org/index.php?title=Adding_public_IP_addresses&type=revision&diff=14981&oldid=14715
Created attachment 14745 [details] Patch for 4.8, 4.9 Patch applies to both v4-8-test and v4-9-test, compiles, "bin/smbtorture x local.file" runs successfully. Do we need to put this though private autobuilds before asking Karolin to apply it to v4-8-test and v4-9-test? I can't imagine it causing any failures anywhere...
It isn't yet team procedure to open merge requests or do private autobuilds for backports, but I've started doing for the same reason as for getting the original patches into master: That CI is (comparatively) cheap and if it saves a round-trip then it is a good thing.
Hi Andrew, Just confirming that you're happy for this to go into 4.8 and 4.9? Karolin, hasn't taken this yet, so wanted to make sure... :-)
(In reply to Martin Schwenke from comment #3) Pushed to autobuild-v4-{8,9}-test.
(In reply to Karolin Seeger from comment #4) Pushed to both branches. Closing out bug report. Thanks!