Bug 13681 - samba-4.9.2/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c: 3 * bad expressions ?
Summary: samba-4.9.2/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c: 3 * bad ...
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: 4.9.2
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-12 09:42 UTC by David Binderman
Modified: 2021-03-22 02:23 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2018-11-12 09:42:23 UTC 
> [samba-4.9.2/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c:156]: (error) Invalid strncmp() argument nr 3. A non-boolean value is required.
> [samba-4.9.2/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c:191]: (error) Invalid strncmp() argument nr 3. A non-boolean value is required.
> [samba-4.9.2/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c:209]: (error) Invalid strncmp() argument nr 3. A non-boolean value is required.

The first one is

       if (strncmp("groupChange", value, strlen("groupChange") != 0)) {

maybe better code


       if (strncmp("groupChange", value, strlen("groupChange")) != 0) {
Comment 1 Andrew Bartlett 2021-03-22 02:23:11 UTC 
Fixed in Samba 4.10 and later by eea1d4b7782fd2a7741e0c3144900b8b9272bfec

Sorry for the late bug update.