Giving the following scenario: 1. Samba server used for some time *without* any of the streams modules and with macOS clients. 2. When macOS clients create files on the server, the macOS internal APIs will create AppleDouble files (._FILE) on the server. 3. These AppleDouble contain the following marshalled data, some of it optional: a) FinderInfo (mandatory, fixed size 32 bytes) b) Extended Attributes (optional, variable size, if present part of FinderInfo) c) Resource Fork (optional, variable size) 4. vfs_fruit is enabled on the server 5. vfs_fruit has a conversion routing to migrate the above data from the AppleDouble file to the stream backend, unfortunately 3a is tied to 3b, that is FinderInfo only gets migrated if the AppleDouble file only contains xattr data. As the latter is only optional, for many AppleDouble files we fail to convert correctly.
Created attachment 14527 [details] Patch for 4.8 and 4.9 cherry-picked from master
Comment on attachment 14527 [details] Patch for 4.8 and 4.9 cherry-picked from master LGTM.
Re-assigning to Karolin for inclusion in 4.9.next, 4.8.next.
(In reply to Jeremy Allison from comment #3) Pushed to autobuild-v4-{9,8}-test.
(In reply to Karolin Seeger from comment #4) Pushed to both branches. Closing out bug report. Thanks!
Created attachment 14553 [details] Follow-up patch for 4.8 and 4.9, cherry-picked from master
Comment on attachment 14553 [details] Follow-up patch for 4.8 and 4.9, cherry-picked from master LGTM.
Re-assigning back to Karolin for inclusion in 4.9.next, 4.8.next.
Karolin, please push the following dependent bugs in this order: bug 13649 (this one) bug 13642 bug 13646
Pushed follw-up patch to autobuild-v4-{9,8}-test.
(In reply to Karolin Seeger from comment #10) Pushed to both branches. Closing out bug report. Thanks!