Bug 13631 - DFS fix for AIX broken
Summary: DFS fix for AIX broken
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 4.9.1
Hardware: PPC AIX
: P5 regression (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-24 12:07 UTC by Ayappan
Modified: 2022-04-04 12:49 UTC (History)
1 user (show)

See Also:

Attachments
backported patch for 4.14, 4.15 and 4.16 (2.73 KB, patch)
2022-02-19 22:35 UTC, Björn Jacke 		metze: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ayappan 2018-09-24 12:07:47 UTC 
https://bugzilla.samba.org/show_bug.cgi?id=6330

This had a fix for DFS issue in AIX. Sometime (or for a quiet long time) back, there is a check to determine "HAVE_BROKEN_READLINE" in the configure. Now nowhere i can this check and the code in source3/smbd/msdfs.c "#if defined (HAVE_BROKEN_READLINE)" never pass through and the DFS problem is back again in AIX.
Comment 1 Ayappan 2018-10-24 10:04:54 UTC 
Any update on this ?
Comment 2 Ayappan 2018-11-07 09:06:10 UTC 
Can somebody look into this ?
Comment 3 Ayappan 2019-01-23 13:15:03 UTC 
Any updates ?
Comment 4 SATOH Fumiyasu 2019-03-24 03:39:18 UTC 
s/HAVE_BROKEN_READLINE/HAVE_BROKEN_READLINK/

I've confirmed. Hmmmmmm.

```
$ grep -r HAVE_BROKEN_READLINK samba-4.10.0
samba-4.10.0/source3/smbd/msdfs.c:#if defined(HAVE_BROKEN_READLINK)
$ /usr/local/samba-4.10.0/sbin/smbd -b |grep HAVE_BROKEN_READLINK
zsh: done       /usr/local/samba-4.10.0/sbin/smbd -b |
zsh: exit 1     grep HAVE_BROKEN_READLINK
```
Comment 5 Samba QA Contact 2022-02-18 23:25:22 UTC 
This bug was referenced in samba master:

e225ab70db0cc01454d319eaca5265d7e33f396c
45cb14ac80889ac913f7f76dbfaebcb4d5ee14fd
Comment 6 Björn Jacke 2022-02-19 22:35:36 UTC 
Created attachment 17172 [details]
backported patch for 4.14, 4.15 and 4.16
Comment 7 Jule Anger 2022-02-27 16:27:57 UTC 
Pushed to autobuild-v4-{16,15,14}-test.
Comment 8 Samba QA Contact 2022-02-27 17:35:06 UTC 
This bug was referenced in samba v4-15-test:

7ce02fab320cb4d107b502a2a4e7a7e9b6e47006
f7e31127e7f8beb12294c5187cca9e191589ddcc
Comment 9 Samba QA Contact 2022-02-27 17:49:03 UTC 
This bug was referenced in samba v4-14-test:

26911b1489d6f6b73bfa60ac19d0c0cc4aedb745
992a41e5e74debc957105d2b50c6172ce93846a0
Comment 10 Samba QA Contact 2022-02-27 20:25:15 UTC 
This bug was referenced in samba v4-16-test:

76463193044cdbcf96a7199fa4bf4ef45a5b2513
2d87ade08a6f03e34428c8ff0793be8f1552b685
Comment 11 Jule Anger 2022-02-28 09:21:48 UTC 
Closing out bug report.

Thanks!
Comment 12 Samba QA Contact 2022-03-01 08:43:10 UTC 
This bug was referenced in samba v4-16-stable (Release samba-4.16.0rc4):

76463193044cdbcf96a7199fa4bf4ef45a5b2513
2d87ade08a6f03e34428c8ff0793be8f1552b685
Comment 13 Samba QA Contact 2022-03-15 13:21:48 UTC 
This bug was referenced in samba v4-15-stable (Release samba-4.15.6):

7ce02fab320cb4d107b502a2a4e7a7e9b6e47006
f7e31127e7f8beb12294c5187cca9e191589ddcc
Comment 14 Samba QA Contact 2022-04-04 12:49:17 UTC 
This bug was referenced in samba v4-14-stable (Release samba-4.14.13):

26911b1489d6f6b73bfa60ac19d0c0cc4aedb745
992a41e5e74debc957105d2b50c6172ce93846a0