Bug 13626 - ldb_ldb module dependency incorrect
Summary: ldb_ldb module dependency incorrect
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL: https://lists.samba.org/archive/samba...
Depends on:
Reported: 2018-09-21 05:42 UTC by Andrew Bartlett
Modified: 2018-09-25 05:53 UTC (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2018-09-21 05:42:45 UTC
As reported by Amitay Isaacs :


In commit 19be0be232c25250e79dc313fd43829de049b491, a dependency of
'ldb_tdb' was added to 'ldb_ldb' module.  That is wrong.  It should be
the library 'ldb_tdb_int'.

Here is the what you get if you build ldb 1.5.1.

$ ./configure --prefix=/tmp/ldb-1.5.1
$ make
$ make install

$ ldd /tmp/ldb-1.5.1/modules/ldb/ldb.so
    linux-vdso.so.1 (0x00007ffe7cda9000)
    libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fbcef08e000)
    libldb.so.1 => /tmp/ldb-1.5.1/lib/libldb.so.1 (0x00007fbceee54000)
    libldb-key-value.so => /tmp/ldb-1.5.1/lib/ldb/libldb-key-value.so
    libldb_module_tdb.so => not found
    libldb-mdb-int.so => /tmp/ldb-1.5.1/lib/ldb/libldb-mdb-int.so
    libtdb.so.1 => /tmp/ldb-1.5.1/lib/ldb/libtdb.so.1 (0x00007fbcee81d000)
    libtevent.so.0 => /tmp/ldb-1.5.1/lib/ldb/libtevent.so.0 (0x00007fbcee606000)
    libldb-tdb-err-map.so =>
/tmp/ldb-1.5.1/lib/ldb/libldb-tdb-err-map.so (0x00007fbcee404000)
    libldb-tdb-int.so => /tmp/ldb-1.5.1/lib/ldb/libldb-tdb-int.so
    libtalloc.so.2 => /tmp/ldb-1.5.1/lib/ldb/libtalloc.so.2 (0x00007fbcedff5000)
    libbsd.so.0 => /lib64/libbsd.so.0 (0x00007fbcedddf000)
    libcrypt.so.1 => /lib64/libcrypt.so.1 (0x00007fbcedbb6000)
    libdl.so.2 => /lib64/libdl.so.2 (0x00007fbced9b2000)
    liblmdb.so.0.0.0 => /lib64/liblmdb.so.0.0.0 (0x00007fbced79d000)
    libc.so.6 => /lib64/libc.so.6 (0x00007fbced3de000)
    /lib64/ld-linux-x86-64.so.2 (0x00007fbcef4af000)
    librt.so.1 => /lib64/librt.so.1 (0x00007fbced1d6000)

There is a missing dependency on libldb_module_tdb.so.

What component should I file the ldb bug?

Comment 1 Amitay Isaacs 2018-09-25 02:22:30 UTC
This is not a bug in 4.9 as we are still using LDB 1.4.2 there.

This should really be filed against LDB 1.5.0/1.5.1.
Comment 2 Andrew Bartlett 2018-09-25 04:03:31 UTC
Thanks for the clarification.

However the code looks similar, are you sure the same issue isn't present there?
Comment 3 Amitay Isaacs 2018-09-25 05:39:34 UTC
Well it's the patch that added tdb_int private library.  In samba 4.9, that code is not backported.  So ldb 1.4.2 does not have the same issue.

I noticed the problem when I was building RPMs for ctdb testing.  I could not install RPMs for LDB 1.5.0 and 1.5.1.  It complaining about missing dependency. That's how I noticed the issue.
Comment 4 Andrew Bartlett 2018-09-25 05:53:14 UTC
Fixed in master by 3b94d31d2478455cd4f370be76da2733216e7041 for Samba 4.10