User reports problems on AIX with new smb2 quota support see https://lists.samba.org/archive/samba-technical/2018-August/thread.html#129551 However I am getting ../source3/smbd/smb2_getinfo.c: In function ‘smbd_smb2_getinfo_send’: ../source3/smbd/smb2_getinfo.c:584:3: error: implicit declaration of function ‘smbd_do_query_getinfo_quota’ [-Werror=implicit-function-declaration] status = smbd_do_query_getinfo_quota(tmp_ctx, ^ ../source3/smbd/smb2_getinfo.c:584:10: error: incompatible types when assigning to type ‘NTSTATUS’ from type ‘int’ status = smbd_do_query_getinfo_quota(tmp_ctx, ^ when quota support is not detected. Still bad of course. Not sure why build doesn't fail for user. I don't understand though how smbd_do_query_getinfo_quota is getting called if the share doesn't have quota support enabled (which it can't as the flag to indicate that is also controlled by HAVE_SYS_QUOTA) There is an additional problem reported to do with the detection of quota support not being detected properly on AIX. Not having access to AIX I can't really do more (will request reporter to open a separate bug with as much useful info as possible)
Created attachment 14399 [details] proposed master fix for issue
Comment on attachment 14399 [details] proposed master fix for issue Reporter of the issue on the mail list confirmed the patch helped please see. https://lists.samba.org/archive/samba-technical/2018-August/129576.html There is still the issue of AIX not detecting quotas. I am not sure if that is correct or not, it's quite possible the quota implementation available on AIX is not compatible for the samba quota support and maybe the configure is correct. I'm hoping the reporter can chase this further, I can't without access to AIX. In anycase that is a entirely separate issue (if indeed it is an issue, which is why I haven't opened a bug for that yet)
Created attachment 14403 [details] backport of patch to 4.8
Created attachment 14404 [details] backport of patch to 4.9
Comment on attachment 14399 [details] proposed master fix for issue Pushed !
Re-assigning to Karolin for inclusion in 4.9.next, 4.8.next.
(In reply to Jeremy Allison from comment #6) Pushed to autobuild-v4-{9,8}-test.
(In reply to Karolin Seeger from comment #7) Pushed to both branches. Closing out bug report. Thanks!