Bug 13544 - emulate/traffic: fix next() usage
Summary: emulate/traffic: fix next() usage
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Python (show other bugs)
Version: 4.9.0rc1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jelmer Vernooij
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-25 22:48 UTC by Joe Guo (mail address dead)
Modified: 2020-05-14 13:36 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Guo (mail address dead) 2018-07-25 22:48:51 UTC 
In commit b0c9de82, line 343:

    self.next_conversation_id = itertools.count().next

was changed to:

    self.next_conversation_id = next(itertools.count())

which is not correct, the first one is a function, the second one is a
int. This will cause the script/traffic_replay script fail to work.

A Merge Request has already been created on gitlab:

https://gitlab.com/samba-team/samba/merge_requests/33
Comment 1 Douglas Bagnall 2019-02-24 06:01:31 UTC 
This has been fixed for a while in master.

Joe: do we need a backport to 4.9 or can we just close it?
Comment 2 Rowland Penny 2020-05-14 13:36:48 UTC 
closing bug report, fixed in all supported versions