Bug 13531 - Fix flapping tests that use pstree
Summary: Fix flapping tests that use pstree
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: CTDB (show other bugs)
Version: 4.9.0rc1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
Depends on:
Reported: 2018-07-15 06:41 UTC by Martin Schwenke
Modified: 2018-08-13 10:43 UTC (History)
2 users (show)

See Also:

Patches for 4.9.x (4.99 KB, patch)
2018-07-19 01:30 UTC, Amitay Isaacs
martins: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Schwenke 2018-07-15 06:41:17 UTC
These tests appear to flap because:

1. pstree truncates long output lines by default
2. A couple of recent commits lengthen the commands printed by pstree in CTDB's tests
3. Autobuild on sn-devel uses quite a deep directory prefix
4. The width of the PID in the pstree output changes

This can be avoided by using the pstree -l option.
Comment 1 Amitay Isaacs 2018-07-19 01:30:46 UTC
Created attachment 14328 [details]
Patches for 4.9.x
Comment 2 Martin Schwenke 2018-07-19 04:51:03 UTC
Hi Karolin,

This is ready for 4.9.

Comment 3 Karolin Seeger 2018-07-28 04:09:12 UTC
Pushed to autobuild-v4-9-test.
Comment 4 Martin Schwenke 2018-08-08 22:56:02 UTC
Hi Karolin,

These landed a while ago in v4-9-stable as:


Should we close this?  Just making sure you're not waiting for something else...
Comment 5 Karolin Seeger 2018-08-13 10:43:52 UTC
(In reply to Martin Schwenke from comment #4)
Right. Closing out bug report.