Bug 13526 - Hard link creation time
Summary: Hard link creation time
Status: RESOLVED FIXED
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.2.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-12 17:17 UTC by jief
Modified: 2020-04-27 01:50 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jief 2018-07-12 17:17:10 UTC 
This is for creation time patch.

The 2nd hard link is reported that its creation time is modified. I traced into rsync and the creation time is the one of the file just before it.

I think I got it :
after this, in recv_file_entry(), in flist.c, line 787 in version 3.1.3
  if (first_hlink_ndx >= flist->ndx_start) {
    struct file_struct *first = flist->files[first_hlink_ndx - flist->ndx_start];
    file_length = F_LENGTH(first);

we should add "crtime = f_crtime(first);" just after.
Comment 1 Wayne Davison 2020-04-27 01:50:06 UTC 
Indeed, you are exactly right about that assignment being missing. I've committed a fix into the rsync-patches git repo.