Bug 13524 - Behavior depends on stacking order: recycle and full_audit
Summary: Behavior depends on stacking order: recycle and full_audit
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 4.8.2
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
Depends on:
Reported: 2018-07-11 20:06 UTC by Andreas Hasenack
Modified: 2018-07-13 12:57 UTC (History)
0 users

See Also:

level 10 logs (75.75 KB, text/plain)
2018-07-11 20:06 UTC, Andreas Hasenack
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Hasenack 2018-07-11 20:06:52 UTC
Created attachment 14320 [details]
level 10 logs

We got a report in Ubuntu against samba 4.3.11 that I was able to reproduce in 4.8.2: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/17804634

When stacking the vfs modules like this, both work:
vfs objects = full_audit recycle

I get the recycle behavior, and the audit logging.

But when switching their ordering, I lose the audit module's logging:
vfs objects = recycle full_audit

I didn't see anything about ordering mentioned in the respective manpages.

Attached are level 10 logs tracking the removal of a file called "apt-cdrom" with a share configured like this:
        comment = storage share
        path = /storage
        vfs objects = recycle full_audit
        read only = no
        guest ok = no
        full_audit:prefix = %u|%I
        full_audit:success = unlink
        full_audit:failure = none
Comment 1 Andreas Hasenack 2018-07-11 20:07:14 UTC
I checked the release notes for 4.8.3 and didn't see anything related to vfs, so I didn't test with that version.
Comment 2 Björn Jacke 2018-07-12 22:03:42 UTC
that link is giving me: "Lost something? This page does not exist, or you may not have permission to see it."

Please always report bugs here with the full information contained in the bug here (and not in a link).

Comment 3 Andreas Hasenack 2018-07-13 12:09:40 UTC
Apologies for the mistake. This is the correct link:


It just has a bit of history, the core of the information should be enough in what I reported here, but do please ask for more if needed. I gave the share definition, and the working and non-working conditions.
Comment 4 Björn Jacke 2018-07-13 12:22:28 UTC
comment 0 does not contain any description of the problem it start with "When stacking the vfs modules like this, both work".

Again, please provide a bug description and if possible a reproducer here and not a link with a bug desription at some other place.
Comment 5 Andreas Hasenack 2018-07-13 12:57:31 UTC
You mean the line just below the phrase you quoted?

> When stacking the vfs modules like this, both work:
> vfs objects = full_audit recycle

That is showing the vfs modules "full_audit" and "recycle" stacked in the shown order.

Then I show the non-working ordering:

vfs objects = recycle full_audit

And then I show the share, and attached a debug level 10.