Bug 13522 - Patch fileflags.diff and crtimes.diff
Summary: Patch fileflags.diff and crtimes.diff
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.1.3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
Depends on:
Reported: 2018-07-11 15:23 UTC by jief
Modified: 2019-03-16 18:39 UTC (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description jief 2018-07-11 15:23:42 UTC
rsync won't compile anymore after applying these 2 patches.

Error:  too few arguments to function call, expected 4, have 2
File : rsync.c
Line : 614 :   for if (cmp_time(sxp->crtime, file_crtime) != 0
Comment 1 Wayne Davison 2018-11-20 21:46:43 UTC
I fixed the patches git repo to have the right cmp_time() calls. I did not test the resulting patch, though, since I don't have an appropriate computer to try it out on.
Comment 2 jief 2018-11-21 12:41:52 UTC

I can compile it and use it (I use rsync almost every day). I'm not saying it'll comprehensive tests will all use cases possible, but it'll be some tests.

But where can I get the source. Can only see the tar ball of 3.1.3 on home page. Is the git public ?

I guess it is reasonably safe to use the current git version. Or is it a work in progress and I should wait for a release ?

Comment 3 Wayne Davison 2019-01-08 21:58:15 UTC
The download page mentions all of the ways to grab the source, including git:


The git source is safe, as it only contains bug fixes since the last release.
Comment 4 jief 2019-02-08 11:06:18 UTC
I got the same error.
In the patch crtimes.diff, downloaded here : https://git.samba.org/?p=rsync-patches.git;a=blob;f=crtimes.diff;h=178ae05ff854b57fe36e91c938b2959c3a0ed963;hb=master, the line "if (cmp_time(sxp->crtime, file_crtime) != 0" is still there.

Did I downloaded crtimes.diff from the right place ?
Comment 5 Wayne Davison 2019-03-16 18:39:25 UTC
My apologies -- I had committed that change on an different computer and failed to push it to the public repository.  I just found the old commit and pushed it out.