rsync won't compile anymore after applying these 2 patches.
Error: too few arguments to function call, expected 4, have 2
File : rsync.c
Line : 614 : for if (cmp_time(sxp->crtime, file_crtime) != 0
I fixed the patches git repo to have the right cmp_time() calls. I did not test the resulting patch, though, since I don't have an appropriate computer to try it out on.
I can compile it and use it (I use rsync almost every day). I'm not saying it'll comprehensive tests will all use cases possible, but it'll be some tests.
But where can I get the source. Can only see the tar ball of 3.1.3 on home page. Is the git public ?
I guess it is reasonably safe to use the current git version. Or is it a work in progress and I should wait for a release ?
The download page mentions all of the ways to grab the source, including git:
The git source is safe, as it only contains bug fixes since the last release.
I got the same error.
In the patch crtimes.diff, downloaded here : https://git.samba.org/?p=rsync-patches.git;a=blob;f=crtimes.diff;h=178ae05ff854b57fe36e91c938b2959c3a0ed963;hb=master, the line "if (cmp_time(sxp->crtime, file_crtime) != 0" is still there.
Did I downloaded crtimes.diff from the right place ?
My apologies -- I had committed that change on an different computer and failed to push it to the public repository. I just found the old commit and pushed it out.